[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/3] qapi: Add SnapshotInfo.
From: |
Benoît Canet |
Subject: |
Re: [Qemu-devel] [PATCH 1/3] qapi: Add SnapshotInfo. |
Date: |
Wed, 15 Aug 2012 20:14:08 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Le Wednesday 15 Aug 2012 à 12:04:56 (-0600), Eric Blake a écrit :
> On 08/15/2012 08:54 AM, Benoît Canet wrote:
> > Signed-off-by: Benoit Canet <address@hidden>
> > ---
> > qapi-schema.json | 24 ++++++++++++++++++++++++
> > 1 file changed, 24 insertions(+)
> >
> > diff --git a/qapi-schema.json b/qapi-schema.json
> > index a92adb1..8d4df19 100644
> > --- a/qapi-schema.json
> > +++ b/qapi-schema.json
> > @@ -126,6 +126,30 @@
> > 'running', 'save-vm', 'shutdown', 'suspended', 'watchdog' ] }
> >
> > ##
> > +# @SnapshotInfo
> > +#
> > +# @id: unique snapshot id
> > +#
> > +# @name: user choosen name
> > +#
> > +# @vm-state-size: size of the VM state
> > +#
> > +# @date-sec: UTC date of the snapshot
> > +#
> > +# @date-nsec: date in nano seconds
>
I took all the availables fields:
typedef struct QEMUSnapshotInfo {
char id_str[128]; /* unique snapshot id */
/* the following fields are informative. They are not needed for
the consistency of the snapshot */
char name[256]; /* user chosen name */
uint64_t vm_state_size; /* VM state info size */
uint32_t date_sec; /* UTC date of the snapshot */
uint32_t date_nsec;
uint64_t vm_clock_nsec; /* VM clock relative to boot */
} QEMUSnapshotInfo;
> How come we track a subsecond creation time,
>
> > +#
> > +# @vm-clock-sec: VM clock relative to boot
>
> but not a subsecond relative time for the VM clock? Is that additional
> precision available for querying?
This one is vm-clock-nsec I made a typo
>
> I have no problem if you want to squash patches 1 and 2 together into a
> single commit.
ok
Benoît
>
> --
> Eric Blake address@hidden +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
>