[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 08/21] target-i386: convert 'hv_spinlocks' featu
From: |
Eduardo Habkost |
Subject: |
Re: [Qemu-devel] [PATCH 08/21] target-i386: convert 'hv_spinlocks' feature into property |
Date: |
Wed, 15 Aug 2012 17:43:31 -0300 |
On 15/08/2012, at 13:13, Igor Mammedov <address@hidden> wrote:
> Signed-off-by: Igor Mammedov <address@hidden>
> ---
> target-i386/cpu.c | 31 +++++++++++++++++++++++++++++++
> 1 file changed, 31 insertions(+)
>
> diff --git a/target-i386/cpu.c b/target-i386/cpu.c
> index 440e724..777b8ce 100644
> --- a/target-i386/cpu.c
> +++ b/target-i386/cpu.c
> @@ -963,6 +963,32 @@ static void x86_cpuid_set_tsc_freq(Object *obj, Visitor
> *v, void *opaque,
> cpu->env.tsc_khz = value / 1000;
> }
>
> +#if !defined(CONFIG_USER_ONLY)
> +static void x86_get_hv_spinlocks(Object *obj, Visitor *v, void *opaque,
> + const char *name, Error **errp)
> +{
> + int64_t value = hyperv_get_spinlock_retries();
This breaks build if compiling without KVM support, as
hyperv_get_spinlock_retries() is available only if CONFIG_KVM is set
(hyperv_set_spinlock_retries(), on the other hand, is defined as an empty
function if CONFIG_KVM is not set).
> +
> + visit_type_int(v, &value, name, errp);
> +}
> +
> +static void x86_set_hv_spinlocks(Object *obj, Visitor *v, void *opaque,
> + const char *name, Error **errp)
> +{
> + int64_t value;
> +
> + visit_type_int(v, &value, name, errp);
> + if (error_is_set(errp)) {
> + return;
> + }
> + if (!value) {
> + error_set(errp, QERR_PROPERTY_VALUE_BAD, "", name, "0");
> + return;
> + }
> + hyperv_set_spinlock_retries(value);
> +}
> +#endif
> +
> static void cpudef_2_x86_cpu(X86CPU *cpu, x86_def_t *def, Error **errp)
> {
> CPUX86State *env = &cpu->env;
> @@ -1919,6 +1945,11 @@ static void x86_cpu_initfn(Object *obj)
> object_property_add(obj, "tsc-frequency", "int",
> x86_cpuid_get_tsc_freq,
> x86_cpuid_set_tsc_freq, NULL, NULL, NULL);
> +#if !defined(CONFIG_USER_ONLY)
> + object_property_add(obj, "hv_spinlocks", "int",
> + x86_get_hv_spinlocks,
> + x86_set_hv_spinlocks, NULL, NULL, NULL);
> +#endif
> x86_register_cpuid_properties(obj, feature_name);
> x86_register_cpuid_properties(obj, ext_feature_name);
> x86_register_cpuid_properties(obj, ext2_feature_name);
> --
> 1.7.11.2
>
--
Eduardo
- [Qemu-devel] [PATCH 00/21] target-i386: convert CPU features into properties, Igor Mammedov, 2012/08/15
- [Qemu-devel] [PATCH 01/21] target-i386: return Error from cpu_x86_find_by_name(), Igor Mammedov, 2012/08/15
- [Qemu-devel] [PATCH 03/21] target-i386: if x86_cpu_realize() failed report error and do cleanup, Igor Mammedov, 2012/08/15
- [Qemu-devel] [PATCH 06/21] target-i386: xlevel should be more than 0x80000000, move fixup into setter, Igor Mammedov, 2012/08/15
- [Qemu-devel] [PATCH 04/21] target-i386: filter out not TCG features if running without kvm at realize time, Igor Mammedov, 2012/08/15
- [Qemu-devel] [PATCH 08/21] target-i386: convert 'hv_spinlocks' feature into property, Igor Mammedov, 2012/08/15
- Re: [Qemu-devel] [PATCH 08/21] target-i386: convert 'hv_spinlocks' feature into property,
Eduardo Habkost <=
- [Qemu-devel] [PATCH 07/21] target-i386: convert cpuid features into properties, Igor Mammedov, 2012/08/15
- [Qemu-devel] [PATCH 10/21] target-i386: convert 'hv_vapic' feature into property, Igor Mammedov, 2012/08/15
- [Qemu-devel] [PATCH 11/21] target-i386: convert 'check' and 'enforce' features into properties, Igor Mammedov, 2012/08/15
- [Qemu-devel] [PATCH 02/21] target-i386: cpu_x86_register(): report error from property setter, Igor Mammedov, 2012/08/15
- [Qemu-devel] [PATCH 14/21] target-i386: introduce vendor-override property, Igor Mammedov, 2012/08/15