Re: [Qemu-devel] [PATCH v7 1.2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC

[Gerd Hoffmann]

On 08/20/12 10:00, Alon Levy wrote:
>> Hi,
>> 
>>>>> +#ifndef QXL_HAS_IO_MONITORS_CONFIG_ASYNC +#define
>>>>> QXL_HAS_IO_MONITORS_CONFIG_ASYNC 0
>>>> 
>>>> Just delete this and use 
>>>> defined(QXL_HAS_IO_MONITORS_CONFIG_ASYNC).
>>> 
>>> So you are telling me to undo a change that Gerd asked for -
>>> could you please at least debate about the merits of both
>>> approaches? the point of having QXL_HAS_IO_MONITORS_CONFIG_ASYNC
>>> always defined was to allow usage of #if without defined, which
>>> is shorter.
>> 
>> Hmm?  That wasn't that I meant, must have been a tyops. I mean you
>> should just do ...
>> 
>> #ifndef QXL_IO_MONITORS_CONFIG_ASYNC            <--- without
>> *_HAS_* #define QXL_IO_MONITORS_CONFIG_ASYNC $value #endif
>> 
>> then you don't need QXL_HAS_IO_MONITORS_CONFIG_ASYNC (and all the 
>> #ifdefs) at all ...
> 
> So you want me to give the io a value

Well, it has one, right?  [ checking spice-protocol ]  It's 24.

> - at this point I'd rather just add spice-protocol as a submodule,
> then we don't need to do any of this. How about it?

No.  You can build qemu without submodules today as they are used for
ROMS only (which are also provided as precompiled binaries).

Maybe revisit upstream spice packaging?  spice internal usage of
spice-protocol is handled via submodules now.  Are there external users,
other than qemu?  Does it make sense to keep the spice-server /
spice-protocol split in the first place?  Or should spice-server just
provide the protocol headers too?

cheers,
  Gerd