qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH for 1.2] megasas: Fix MinGW compiler warning cau


From: Hannes Reinecke
Subject: Re: [Qemu-devel] [PATCH for 1.2] megasas: Fix MinGW compiler warning caused by illegal type cast
Date: Fri, 24 Aug 2012 10:31:28 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120601 Thunderbird/13.0

On 08/23/2012 11:02 PM, Stefan Weil wrote:
Type casts from pointer to integer values must use uintptr_t
instead of unsigned long. Otherwise the compiler complains on
hosts with sizeof(pointer) != sizeof(long).

The patch also replace magic number 32 by sizeof(info.serial_number)
which has the same value but is better for code reviews.

Signed-off-by: Stefan Weil <address@hidden>

Sigh. I never seem to get the hang of typecasting.

Acked-by: Hannes Reinecke <address@hidden>

Cheers,

Hannes
--
Dr. Hannes Reinecke                   zSeries & Storage
address@hidden                        +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Markus Rex, HRB 16746 (AG Nürnberg)






reply via email to

[Prev in Thread] Current Thread [Next in Thread]