qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 01/10] qom: add, remove of link property need to


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH 01/10] qom: add, remove of link property need to ref, unref its target
Date: Fri, 24 Aug 2012 16:52:41 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120717 Thunderbird/14.0

Il 24/08/2012 11:49, Liu Ping Fan ha scritto:
> From: Liu Ping Fan <address@hidden>
> 
> Currently, link property's target is only managed by
> object_set_link_property(). This will raise such issue that when
> the property is finalized, its target has no opportunity to release.
> 
> Fix this issue by introduce object_finalize_link_property()
> In correspond, ref target when adding link prpoerty.
> 
> Signed-off-by: Liu Ping Fan <address@hidden>
> ---

This patch is fine, but it is at the wrong place in the series.  It will
cause an assertion failure due to the unbroken circular reference.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]