Re: [Qemu-devel] [PATCH for-1.2] target-ppc: fix altivec instructions

[Andreas Färber]

Am 26.08.2012 16:14, schrieb Aurelien Jarno:
> Altivec instructions are not working anymore in PowerPC emulation,
> following commit d15f74fb, which inverted two registers in the call
> to helper. Fix that.
> 
> Cc: Blue Swirl <address@hidden>
> Cc: Alexander Graf <address@hidden>
> Cc: Andreas Färber <address@hidden>
> Signed-off-by: Aurelien Jarno <address@hidden>

Reviewed-by: Andreas Färber <address@hidden>

This looks right, but do you have a particular test case I can check?

Andreas

> ---
>  target-ppc/translate.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/target-ppc/translate.c b/target-ppc/translate.c
> index 91eb7a0..ac915cc 100644
> --- a/target-ppc/translate.c
> +++ b/target-ppc/translate.c
> @@ -6530,7 +6530,7 @@ static void glue(gen_, name)(DisasContext *ctx)         
>                 \
>      ra = gen_avr_ptr(rA(ctx->opcode));                                  \
>      rb = gen_avr_ptr(rB(ctx->opcode));                                  \
>      rd = gen_avr_ptr(rD(ctx->opcode));                                  \
> -    gen_helper_##name(rd, cpu_env, ra, rb);                             \
> +    gen_helper_##name(cpu_env, rd, ra, rb);                             \
>      tcg_temp_free_ptr(ra);                                              \
>      tcg_temp_free_ptr(rb);                                              \
>      tcg_temp_free_ptr(rd);                                              \
> 


-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg