Re: [Qemu-devel] [PATCH] Versatile Express: add modelling of NOR flash

[Peter Maydell]

On 5 September 2012 06:16, Stefan Weil <address@hidden> wrote:
> Am 04.09.2012 19:08, schrieb Francesco Lavra:
>>       /* VE_NORFLASH0ALIAS: not modelled */
>
>
> What about that alias? It's not difficult to add it, too.
> Just look for memory_region_init_alias in the code to
> see how it is done (hw/mips_malta.c has an alias region
> for flash).

It's painful because you might also have to add the logic for
letting the guest map and unmap the alias (which implies
implementing a whole section of the A15 board we don't currently
bother with, the SCC registers). I'd need to check the board
documentation more carefully to see if we can get away with
always mapping that area as the flash alias.

(Also we'd need to fix the current problem with the
motherboard address map arrays that there's no way to
distinguish "peripheral not present on this board" from
"peripheral at address 0", since the A9 board doesn't have
the flash alias.)

More to the point, this is the third attempt at doing this.
Previously Liming Wang sent a patch:
 http://patchwork.ozlabs.org/patch/147905/
and Jagan sent a two-patch set:
 http://patchwork.ozlabs.org/patch/171812/
 http://patchwork.ozlabs.org/patch/171814/

both of which failed in the code review stage. Francesco,
can you check that you haven't fallen into any of the
same problems they did, please?

-- PMM