[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 08/14] qxl/update_area_io: guest_bug on invalid para
From: |
Gerd Hoffmann |
Subject: |
[Qemu-devel] [PATCH 08/14] qxl/update_area_io: guest_bug on invalid parameters |
Date: |
Thu, 6 Sep 2012 09:21:34 +0200 |
From: Alon Levy <address@hidden>
Signed-off-by: Alon Levy <address@hidden>
Signed-off-by: Gerd Hoffmann <address@hidden>
---
hw/qxl.c | 12 ++++++++++++
1 files changed, 12 insertions(+), 0 deletions(-)
diff --git a/hw/qxl.c b/hw/qxl.c
index 95bbc03..baf9bb4 100644
--- a/hw/qxl.c
+++ b/hw/qxl.c
@@ -1386,6 +1386,18 @@ async_common:
QXLCookie *cookie = NULL;
QXLRect update = d->ram->update_area;
+ if (d->ram->update_surface > NUM_SURFACES) {
+ qxl_set_guest_bug(d, "QXL_IO_UPDATE_AREA: invalid surface id %d\n",
+ d->ram->update_surface);
+ return;
+ }
+ if (update.left >= update.right || update.top >= update.bottom) {
+ qxl_set_guest_bug(d,
+ "QXL_IO_UPDATE_AREA: invalid area (%ux%u)x(%ux%u)\n",
+ update.left, update.top, update.right, update.bottom);
+ return;
+ }
+
if (async == QXL_ASYNC) {
cookie = qxl_cookie_new(QXL_COOKIE_TYPE_IO,
QXL_IO_UPDATE_AREA_ASYNC);
--
1.7.1
- [Qemu-devel] [PATCH 02/14] spice: notify spice server on vm start/stop, (continued)
- [Qemu-devel] [PATCH 02/14] spice: notify spice server on vm start/stop, Gerd Hoffmann, 2012/09/06
- [Qemu-devel] [PATCH 05/14] spice: add 'migrated' flag to spice info, Gerd Hoffmann, 2012/09/06
- [Qemu-devel] [PATCH 01/14] spice: abort on invalid streaming cmdline params, Gerd Hoffmann, 2012/09/06
- [Qemu-devel] [PATCH 12/14] spice: make number of surfaces runtime-configurable., Gerd Hoffmann, 2012/09/06
- [Qemu-devel] [PATCH 11/14] configure: print spice-protocol and spice-server versions, Gerd Hoffmann, 2012/09/06
- [Qemu-devel] [PATCH 07/14] spice: increase the verbosity of spice section in "qemu --help", Gerd Hoffmann, 2012/09/06
- [Qemu-devel] [PATCH 13/14] qxl: Add set_client_capabilities() interface to QXLInterface, Gerd Hoffmann, 2012/09/06
- [Qemu-devel] [PATCH 09/14] qxl: disallow unknown revisions, Gerd Hoffmann, 2012/09/06
- [Qemu-devel] [PATCH 10/14] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC, Gerd Hoffmann, 2012/09/06
- [Qemu-devel] [PATCH 04/14] spice migration: add QEVENT_SPICE_MIGRATE_COMPLETED, Gerd Hoffmann, 2012/09/06
- [Qemu-devel] [PATCH 08/14] qxl/update_area_io: guest_bug on invalid parameters,
Gerd Hoffmann <=
- Re: [Qemu-devel] [PULL 00/14] spice patch queue, Aurelien Jarno, 2012/09/10