[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/5] virtio-scsi: Add start/stop functionality f
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH 4/5] virtio-scsi: Add start/stop functionality for vhost-scsi |
Date: |
Mon, 10 Sep 2012 09:24:37 +0300 |
On Mon, Sep 10, 2012 at 08:16:54AM +0200, Paolo Bonzini wrote:
> Il 09/09/2012 00:40, Michael S. Tsirkin ha scritto:
> > On Fri, Sep 07, 2012 at 06:00:50PM +0200, Paolo Bonzini wrote:
> >> Il 07/09/2012 08:48, Nicholas A. Bellinger ha scritto:
> >>> Cc: Stefan Hajnoczi <address@hidden>
> >>> Cc: Zhi Yong Wu <address@hidden>
> >>> Cc: Michael S. Tsirkin <address@hidden>
> >>> Cc: Paolo Bonzini <address@hidden>
> >>> Signed-off-by: Nicholas Bellinger <address@hidden>
> >>> ---
> >>> hw/virtio-pci.c | 2 ++
> >>> hw/virtio-scsi.c | 49 +++++++++++++++++++++++++++++++++++++++++++++++++
> >>> hw/virtio-scsi.h | 1 +
> >>> 3 files changed, 52 insertions(+), 0 deletions(-)
> >>
> >> Please create a completely separate device vhost-scsi-pci instead (or
> >> virtio-scsi-tcm-pci, or something like that). It is used completely
> >> differently from virtio-scsi-pci, it does not make sense to conflate the
> >> two.
> >
> > Ideally the name would say how it is different, not what backend it
> > uses. Any good suggestions?
>
> I chose the backend name because, ideally, there would be no other
> difference. QEMU _could_ implement all the goodies in vhost-scsi (such
> as reservations or ALUA), it just doesn't do that yet.
>
> Paolo
Then why do you say "It is used completely differently from
virtio-scsi-pci"? Isn't it just a different backend?
If yes then it should be a backend option, like it is
for virtio-net.
--
MST
- [Qemu-devel] [PATCH 0/5] vhost-scsi: Add support for host virtualized target, Nicholas A. Bellinger, 2012/09/07
- [Qemu-devel] [PATCH 2/5] vhost: Pass device path to vhost_dev_init(), Nicholas A. Bellinger, 2012/09/07
- [Qemu-devel] [PATCH 3/5] vhost-scsi: add -vhost-scsi host device for use with tcm-vhost, Nicholas A. Bellinger, 2012/09/07
- [Qemu-devel] [PATCH 1/5] monitor: Rename+move net_handle_fd_param -> monitor_handle_fd_param, Nicholas A. Bellinger, 2012/09/07
- [Qemu-devel] [PATCH 4/5] virtio-scsi: Add start/stop functionality for vhost-scsi, Nicholas A. Bellinger, 2012/09/07
- Re: [Qemu-devel] [PATCH 4/5] virtio-scsi: Add start/stop functionality for vhost-scsi, Paolo Bonzini, 2012/09/07
- Re: [Qemu-devel] [PATCH 4/5] virtio-scsi: Add start/stop functionality for vhost-scsi, Michael S. Tsirkin, 2012/09/08
- Re: [Qemu-devel] [PATCH 4/5] virtio-scsi: Add start/stop functionality for vhost-scsi, Paolo Bonzini, 2012/09/10
- Re: [Qemu-devel] [PATCH 4/5] virtio-scsi: Add start/stop functionality for vhost-scsi,
Michael S. Tsirkin <=
- Re: [Qemu-devel] [PATCH 4/5] virtio-scsi: Add start/stop functionality for vhost-scsi, Paolo Bonzini, 2012/09/10
- Re: [Qemu-devel] [PATCH 4/5] virtio-scsi: Add start/stop functionality for vhost-scsi, Michael S. Tsirkin, 2012/09/10
- Re: [Qemu-devel] [PATCH 4/5] virtio-scsi: Add start/stop functionality for vhost-scsi, Anthony Liguori, 2012/09/11
- Re: [Qemu-devel] [PATCH 4/5] virtio-scsi: Add start/stop functionality for vhost-scsi, Michael S. Tsirkin, 2012/09/11
- Re: [Qemu-devel] [PATCH 4/5] virtio-scsi: Add start/stop functionality for vhost-scsi, Nicholas A. Bellinger, 2012/09/13
- Re: [Qemu-devel] [PATCH 4/5] virtio-scsi: Add start/stop functionality for vhost-scsi, Paolo Bonzini, 2012/09/14
- Re: [Qemu-devel] [PATCH 4/5] virtio-scsi: Add start/stop functionality for vhost-scsi, Michael S. Tsirkin, 2012/09/14
- Re: [Qemu-devel] [PATCH 4/5] virtio-scsi: Add start/stop functionality for vhost-scsi, Michael S. Tsirkin, 2012/09/14
[Qemu-devel] [PATCH 5/5] virtio-scsi: Set max_target=0 during vhost-scsi operation, Nicholas A. Bellinger, 2012/09/07
Re: [Qemu-devel] [PATCH 0/5] vhost-scsi: Add support for host virtualized target, Asias He, 2012/09/11