[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qxl: better cleanup for surface destroy
From: |
Alon Levy |
Subject: |
Re: [Qemu-devel] [PATCH] qxl: better cleanup for surface destroy |
Date: |
Tue, 11 Sep 2012 03:23:08 -0400 (EDT) |
> Add back a call to qxl_spice_destroy_surface_wait_complete() in
> qxl_spice_destroy_surface_wait(),
> that was removed by commit c480bb7da465186b84d8427e068ef7502e47ffbf
>
> It is needed to complete surface-removal cleanup, for non async.
> For async, qxl_spice_destroy_surface_wait_complete is called upon
> operation completion.
Looks good. Cc'ing Gerd.
>
> Signed-off-by: Uri Lublin <address@hidden>
> ---
> hw/qxl.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/hw/qxl.c b/hw/qxl.c
> index c2dd3b4..43a2bdf 100644
> --- a/hw/qxl.c
> +++ b/hw/qxl.c
> @@ -196,6 +196,7 @@ static void
> qxl_spice_destroy_surface_wait(PCIQXLDevice *qxl, uint32_t id,
> spice_qxl_destroy_surface_async(&qxl->ssd.qxl, id,
> (uintptr_t)cookie);
> } else {
> qxl->ssd.worker->destroy_surface_wait(qxl->ssd.worker, id);
> + qxl_spice_destroy_surface_wait_complete(qxl, id);
> }
> }
>
> --
> 1.7.1
>
>
>