[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 086/126] target-s390: Convert CLST, MVST
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH 086/126] target-s390: Convert CLST, MVST |
Date: |
Tue, 11 Sep 2012 14:09:28 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120828 Thunderbird/15.0 |
On 09/11/2012 12:11 PM, Blue Swirl wrote:
> PSW_MASK_64 bit could be added to TB flags and that could be checked
> during translation, then the mask needs to be applied only when the
> mode is active. Whether that actually improves performance depends on
> how often the bit is changed. Also all PSW writes need to be handled,
> possibly causing a TB flush.
Actually I'm not sure why we check this at all, given that we only
actually handle 64-bit mode -- at least as documented by the code
implementing the SET ADDRESS MODE instruction.
That said, we do encode the bit in TB flags, and we do perform this
masking for qemu loads performed within the TB. No TB flushes are
required because we simply don't match TBs with different flags.
As for clst, mvst, srst, I thought about performing the masking in
the TB, but didn't figure it was worth it. Do you have an opinion, Alex?
r~
- [Qemu-devel] [PATCH 054/126] target-s390: Convert NC, XC, OC, TR, UNPK, (continued)
- [Qemu-devel] [PATCH 054/126] target-s390: Convert NC, XC, OC, TR, UNPK, Richard Henderson, 2012/09/09
- [Qemu-devel] [PATCH 068/126] target-s390: Convert LLGT, Richard Henderson, 2012/09/09
- [Qemu-devel] [PATCH 070/126] target-s390: Convert FP SUBTRACT, Richard Henderson, 2012/09/09
- [Qemu-devel] [PATCH 058/126] target-s390: Convert SIGP, Richard Henderson, 2012/09/09
- [Qemu-devel] [PATCH 060/126] target-s390: Convert LCTL, STCTL, Richard Henderson, 2012/09/09
- [Qemu-devel] [PATCH 059/126] target-s390: Convert EFPC, STFPC, Richard Henderson, 2012/09/09
- [Qemu-devel] [PATCH 071/126] target-s390: Convert FP DIVIDE, Richard Henderson, 2012/09/09
- [Qemu-devel] [PATCH 088/126] target-s390: Convert STIDP, Richard Henderson, 2012/09/09
- [Qemu-devel] [PATCH 086/126] target-s390: Convert CLST, MVST, Richard Henderson, 2012/09/09
- [Qemu-devel] [PATCH 087/126] target-s390: Convert SRST, Richard Henderson, 2012/09/09
- [Qemu-devel] [PATCH 089/126] target-s390: Convert SCK, Richard Henderson, 2012/09/09
- [Qemu-devel] [PATCH 096/126] target-s390: Convert STAP, Richard Henderson, 2012/09/09
- [Qemu-devel] [PATCH 098/126] target-s390: Convert ISKE, Richard Henderson, 2012/09/09
- [Qemu-devel] [PATCH 097/126] target-s390: Convert IPTE, Richard Henderson, 2012/09/09
- [Qemu-devel] [PATCH 100/126] target-s390: Convert RRBE, Richard Henderson, 2012/09/09
- [Qemu-devel] [PATCH 101/126] target-s390: Convert subchannel instructions, Richard Henderson, 2012/09/09
- [Qemu-devel] [PATCH 099/126] target-s390: Convert SSKE, Richard Henderson, 2012/09/09
- [Qemu-devel] [PATCH 090/126] target-s390: Convert STCK, Richard Henderson, 2012/09/09