|
From: | Richard Henderson |
Subject: | Re: [Qemu-devel] [PATCH 1/9] NiosII: Add support for the Altera NiosII soft-core CPU. |
Date: | Tue, 11 Sep 2012 15:30:29 -0700 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120828 Thunderbird/15.0 |
On 09/11/2012 02:34 PM, Aurelien Jarno wrote: > Minor nitpick: it's better to write: > > tcg_gen_add_tl(addr, addr, dc->cpu_R[instr->a]); > > as the code generator on non-RISC hosts usually generate a slightly tiny > better code. You know... we already swap operands for constants. It would be trivial have tcg_constant_folding swap for matching operands at the same time. r~
[Prev in Thread] | Current Thread | [Next in Thread] |