Re: [Qemu-devel] [PATCH v2 06/16] block: do not parse BDRV_O_CACHE_WB in raw block drivers

[Paolo Bonzini]

Il 13/09/2012 23:45, Jeff Cody ha scritto:
> While there are more changes this way, I think it cleans up the code a
> bit.  The advantage is that bs->open_flags actually reflects the open
> flags that are currently in use.  One disadvantage I see is that it
> seems a bit odd to have BDRV_O_CACHE_WCE cleared and BDRV_O_CACHE_WB
> set, until you think about them being intended for different layers.

It's more weird to see BDRV_O_CACHE_WCE set and BDRV_O_CACHE_WB cleared. :)

> Maybe that is part of the underlying problem - there is one open_flags
> variable in the BDS, that has some flags intended for all layers in the
> block stack, and some flags specific to a layer.

Yes, that's true.

Paolo