[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH 04/10] tcg: change cpu_restore_state to retu
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [RFC PATCH 04/10] tcg: change cpu_restore_state to return void |
Date: |
Mon, 17 Sep 2012 18:20:35 +0100 |
On 17 September 2012 18:09, Paolo Bonzini <address@hidden> wrote:
> Il 17/09/2012 19:06, Peter Maydell ha scritto:
>>> > The return value is used nowhere.
>> ...it looks like we should probably assert() rather than ploughing
>> blindly forward if we try to restore state to match a PC value and
>> it doesn't work for some reason.
>
> Couldn't that mean simply that the tb for instance wasn't mapped
> anywhere? That's the KVM case, at least.
Hmm. For TCG there are certainly some cases where failure to
cpu_restore_state() means that the current CPU state is now broken;
that should be fatal (and I'm not sure there are any cases where
failure is OK. I think calls are generally protected by
checking that tb_find_pc() returned non-NULL, so we shouldn't
be trying to restore state unless we really were in the middle
of a TB that we know about and can translate.)
I'm not sure what the TB concept means for KVM -- after all KVM
doesn't do any translation...
-- PMM
- [Qemu-devel] [RFC PATCH 09/10] i386: move TCG functions out of helper.o, non-TCG functions to cpu.o, (continued)
- [Qemu-devel] [RFC PATCH 09/10] i386: move TCG functions out of helper.o, non-TCG functions to cpu.o, Paolo Bonzini, 2012/09/17
- [Qemu-devel] [RFC PATCH 07/10] configure: emit summary at the very end, Paolo Bonzini, 2012/09/17
- [Qemu-devel] [RFC PATCH 03/10] vl: implement tcg_enabled() and tcg_available() as for other accelerators, Paolo Bonzini, 2012/09/17
- [Qemu-devel] [RFC PATCH 10/10] build: do not build TCG files if TCG is disabled, Paolo Bonzini, 2012/09/17
- [Qemu-devel] [RFC PATCH 04/10] tcg: change cpu_restore_state to return void, Paolo Bonzini, 2012/09/17
Re: [Qemu-devel] [RFC PATCH 00/10] Add --disable-tcg, Blue Swirl, 2012/09/17