Re: [Qemu-devel] Breakage

[Max Filippov]

On Tue, Sep 18, 2012 at 12:15 AM, Eduardo Habkost <address@hidden> wrote:
> On Mon, Sep 17, 2012 at 11:54:42PM +0400, malc wrote:
>> On Mon, 17 Sep 2012, Anthony Liguori wrote:
>>
>> > malc <address@hidden> writes:
>> >
>> > > Some(thing|one) broke compilation with pcspk enabled.
>> > > Symptoms being:
>> > >
>> > > ../libhw32/hw/pcspk.o: In function `pcspk_io_write':
>> > > /home/malc/x/rcs/git/qemu/hw/pcspk.c:145: undefined reference to 
>> > > `pit_set_gate'
>> > > ../libhw32/hw/pcspk.o: In function `pcspk_io_read':
>> > > /home/malc/x/rcs/git/qemu/hw/pcspk.c:130: undefined reference to 
>> > > `pit_get_channel_info'
>> > > ../libhw32/hw/pcspk.o: In function `pcspk_callback':
>> > > /home/malc/x/rcs/git/qemu/hw/pcspk.c:81: undefined reference to 
>> > > `pit_get_channel_info'
>> > > collect2: ld returned 1 exit status
>> >
>> > Try cleaning your build directory.
>> >
>> > It builds fine for me.
>> >
>>
>> --target-list=xtensa-softmmu --audio-card-list=pcspk
>
> It looks like this particular configuration never worked, since
> xtensa-softmmu was introduced (commit 
> cfa550c6acc6718c3f932e858366e3e1e81266d6).

Other embedded platforms (I've tried cris-softmmu, lm32-softmmu, or32-softmmu,
sh4-softmmu) give the same result.

> Does it even make sense to have a PC-speaker on a Xtensa machine?
> Should the machine have a i8254 PIT?

I doubt that it's meaningful for any of the mentioned _architectures_,
definitely not for xtensa.

-- 
Thanks.
-- Max