[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 02/19] block: make bdrv_set_enable_write_cache()
From: |
Jeff Cody |
Subject: |
[Qemu-devel] [PATCH v3 02/19] block: make bdrv_set_enable_write_cache() modify open_flags |
Date: |
Tue, 18 Sep 2012 14:53:07 -0400 |
bdrv_set_enable_write_cache() sets the bs->enable_write_cache flag,
but without the flag recorded in bs->open_flags, then next time
a reopen() is performed the enable_write_cache setting may be
inadvertently lost.
This will set the flag in open_flags, so it is preserved across
reopens.
Signed-off-by: Jeff Cody <address@hidden>
---
block.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/block.c b/block.c
index c3eb585..2b96c8e 100644
--- a/block.c
+++ b/block.c
@@ -2164,6 +2164,13 @@ int bdrv_enable_write_cache(BlockDriverState *bs)
void bdrv_set_enable_write_cache(BlockDriverState *bs, bool wce)
{
bs->enable_write_cache = wce;
+
+ /* so a reopen() will preserve wce */
+ if (wce) {
+ bs->open_flags |= BDRV_O_CACHE_WB;
+ } else {
+ bs->open_flags &= ~BDRV_O_CACHE_WB;
+ }
}
int bdrv_is_encrypted(BlockDriverState *bs)
--
1.7.11.4
- [Qemu-devel] [PATCH v3 10/19] block: raw image file reopen, (continued)
- [Qemu-devel] [PATCH v3 10/19] block: raw image file reopen, Jeff Cody, 2012/09/18
- [Qemu-devel] [PATCH v3 12/19] block: qcow2 image file reopen, Jeff Cody, 2012/09/18
- [Qemu-devel] [PATCH v3 13/19] block: qcow image file reopen, Jeff Cody, 2012/09/18
- [Qemu-devel] [PATCH v3 14/19] block: vmdk image file reopen, Jeff Cody, 2012/09/18
- [Qemu-devel] [PATCH v3 01/19] block: correctly set the keep_read_only flag, Jeff Cody, 2012/09/18
- [Qemu-devel] [PATCH v3 08/19] block: purge s->aligned_buf and s->aligned_buf_size from raw-posix.c, Jeff Cody, 2012/09/18
- [Qemu-devel] [PATCH v3 17/19] block: vpc image file reopen, Jeff Cody, 2012/09/18
- [Qemu-devel] [PATCH v3 15/19] block: raw-win32 driver reopen support, Jeff Cody, 2012/09/18
- [Qemu-devel] [PATCH v3 11/19] block: qed image file reopen, Jeff Cody, 2012/09/18
- [Qemu-devel] [PATCH v3 18/19] block: convert bdrv_commit() to use bdrv_reopen(), Jeff Cody, 2012/09/18
- [Qemu-devel] [PATCH v3 02/19] block: make bdrv_set_enable_write_cache() modify open_flags,
Jeff Cody <=
- [Qemu-devel] [PATCH v3 16/19] block: vdi image file reopen, Jeff Cody, 2012/09/18
- [Qemu-devel] [PATCH v3 19/19] block: remove keep_read_only flag from BlockDriverState struct, Jeff Cody, 2012/09/18