[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v7 1/5] sockets: Make inet_parse() non static.
From: |
Bharata B Rao |
Subject: |
Re: [Qemu-devel] [PATCH v7 1/5] sockets: Make inet_parse() non static. |
Date: |
Thu, 20 Sep 2012 11:27:54 +0530 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Tue, Sep 18, 2012 at 02:57:59PM +0200, Paolo Bonzini wrote:
> Il 18/09/2012 14:47, Kevin Wolf ha scritto:
> >> > Makefile.objs | 2 +-
> >> > qemu-config.c | 31 +++++++++++++++++++++++++++++++
> >> > qemu-sockets.c | 42 ++++++------------------------------------
> >> > qemu_socket.h | 1 +
> >> > 4 files changed, 39 insertions(+), 37 deletions(-)
> > Making the option list global sounds fine, but I don't think it should
> > be moved to qemu-config.c or added to vm_config_groups, which is
> > generally used for command line options and config file entries. At
> > least I can't imagine a command line option -inet would be very useful.
>
> Yes. Also, I'll send a pull-request for
> http://patchwork.ozlabs.org/patch/180237/ soon, so you might as well
> take that patch.
Ok, this patch is good enough for gluster usecase. I will include this in my
v8 post if its not upstream by that time.
Regards,
Bharata.
[Qemu-devel] [PATCH v7 3/5] aio: Fix qemu_aio_wait() to maintain correct walking_handlers count, Bharata B Rao, 2012/09/17
[Qemu-devel] [PATCH v7 4/5] configure: Add a config option for GlusterFS as block backend, Bharata B Rao, 2012/09/17
[Qemu-devel] [PATCH v7 5/5] block: Support GlusterFS as a QEMU block backend., Bharata B Rao, 2012/09/17