Re: [Qemu-devel] [PATCH 35/41] buffered_file: buffered_put_buffer() don't need to set last_error

[Paolo Bonzini]

Il 21/09/2012 10:47, Juan Quintela ha scritto:
> Callers on savevm.c:qemu_fflush() will set it.
> 
> Signed-off-by: Juan Quintela <address@hidden>
> ---
>  buffered_file.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/buffered_file.c b/buffered_file.c
> index 6d9a50b..318d0f0 100644
> --- a/buffered_file.c
> +++ b/buffered_file.c
> @@ -120,8 +120,6 @@ static int buffered_put_buffer(void *opaque, const 
> uint8_t *buf, int64_t pos, in
>      error = buffered_flush(s);
>      if (error < 0) {
>          DPRINTF("buffered flush error. bailing: %s\n", strerror(-error));
> -        qemu_file_set_error(s->file, error);
> -
>          return error;
>      }
> 

Yo dawg, I heard you like buffers so I put a buffer in your buffered
file so you buffer while the file buffers.

Reviewed-by: Paolo Bonzini <address@hidden>