[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/3] hmp: dump-guest-memory: hardcode protocol a
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH 3/3] hmp: dump-guest-memory: hardcode protocol argument to file: |
|
Date: |
Fri, 21 Sep 2012 12:13:39 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120828 Thunderbird/15.0 |
On 09/21/2012 11:07 AM, Luiz Capitulino wrote:
> Today, it's necessary to specify the protocol you want to use
> when dumping the guest memory, for example:
>
> (qemu) dump-guest-memory file:/tmp/guest-memory
>
> This has a few issues:
>
> 1. It's cumbersome to type
> 2. We loose file path autocompletion
> 3. Being able to specify fd:X in HMP makes little sense for humans
>
> Because of these reasons, hardcode the 'protocol' argument to
> 'file:' in HMP.
No impact to libvirt as a QMP client, and we've already declared that
HMP can change for better UI even if it is not back-compatible.
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake address@hidden +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature