[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 00/10] tcg/mips: cleanup and improvements
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH 00/10] tcg/mips: cleanup and improvements |
Date: |
Fri, 21 Sep 2012 12:33:32 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120828 Thunderbird/15.0 |
On 09/21/2012 09:43 AM, Aurelien Jarno wrote:
> This patch series first does a bit of cleanup and bug fixing on the
> MIPS TCG backend. Then some optimizations are added, mostly by
> implementing new TCG operations. The last patch depends on the movcond
> series by Richard Henderson.
>
> This has been tested on Loongson3A and Octeon CPUs by booting arm, i386,
> x86_64 and ppc guests.
>
> Aurelien Jarno (10):
> tcg-mips: fix wrong usage of 'Z' constraint
> tcg/mips: kill warnings in user mode
> tcg/mips: use TCGArg or TCGReg instead of int
> tcg/mips: don't use global pointer
> tcg/mips: use stack for TCG temps
> tcg/mips: optimize brcond arg, 0
> tcg/mips: optimize bswap{16,16s,32} on MIPS32R2
> tcg/mips: implement rotl/rotr ops on MIPS32R2
> tcg/mips: implement deposit op on MIPS32R2
> tcg/mips: implement movcond op on MIPS32R2
>
> tcg/mips/tcg-target.c | 336
> +++++++++++++++++++++++++++++++++++--------------
> tcg/mips/tcg-target.h | 25 +++-
> 2 files changed, 266 insertions(+), 95 deletions(-)
>
While I didn't double-check the actual instruction encodings, I looked
through the patches for typos and logic errors. I didn't see anything
except for patch 4 re the handling of the global pointer. That patch
is fine as written, though I believe it could be improved.
Reviewed-by: Richard Henderson <address@hidden>
r~
- [Qemu-devel] [PATCH 10/10] tcg/mips: implement movcond op on MIPS32R2, (continued)
[Qemu-devel] [PATCH 02/10] tcg/mips: kill warnings in user mode, Aurelien Jarno, 2012/09/21
[Qemu-devel] [PATCH 06/10] tcg/mips: optimize brcond arg, 0, Aurelien Jarno, 2012/09/21
[Qemu-devel] [PATCH 03/10] tcg/mips: use TCGArg or TCGReg instead of int, Aurelien Jarno, 2012/09/21
Re: [Qemu-devel] [PATCH 00/10] tcg/mips: cleanup and improvements,
Richard Henderson <=