[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/3] qmp: qmp_send_key(): accept key codes in he
|
From: |
Avi Kivity |
|
Subject: |
Re: [Qemu-devel] [PATCH 2/3] qmp: qmp_send_key(): accept key codes in hex |
|
Date: |
Sun, 23 Sep 2012 10:49:07 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120828 Thunderbird/15.0 |
On 09/21/2012 09:20 PM, Eric Blake wrote:
> On 09/21/2012 12:18 PM, Eric Blake wrote:
> >> Any better ideas?
> >
> > Maybe s/hex/number/, as in:
> >
> > JSON: 'number':0x20
> >
> > C code: keylist->value->number = number;
> >
> > that is, you are passing the value either as a keycode name, or as a number.
>
> Or even s/hex/int/
>
> except that the C code would then have to use mangling (since the JSON
> name would match a C keyword).
>
'keycode'?
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
[Qemu-devel] [PATCH 3/3] input: index_from_key(): drop unused code, Luiz Capitulino, 2012/09/21
[Qemu-devel] [PATCH 1/3] input: qmp_send_key(): simplify, Luiz Capitulino, 2012/09/21
Re: [Qemu-devel] [PATCH v2 0/3]: qmp: send-key: accept key codes in hex, Eric Blake, 2012/09/21