[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 4/7] block: helper function, to find the base
From: |
Jeff Cody |
Subject: |
Re: [Qemu-devel] [PATCH v2 4/7] block: helper function, to find the base image of a chain |
Date: |
Tue, 25 Sep 2012 15:45:28 -0400 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120828 Thunderbird/15.0 |
On 09/25/2012 03:13 PM, Eric Blake wrote:
> On 09/25/2012 10:29 AM, Jeff Cody wrote:
>> This is a simple helper function, that will return the base image
>> of a given image chain.
>>
>> Signed-off-by: Jeff Cody <address@hidden>
>> ---
>> block.c | 16 ++++++++++++++++
>> block.h | 1 +
>> 2 files changed, 17 insertions(+)
>
> Bikeshed question: Any reason patch 1/7 adds two helper functions, and
> patch 4/7 adds a third? Perhaps it would be worth squashing all three
> into one commit, or else having three commits, one per helper? But
> there's no point in repainting things now, so:
>
> Reviewed-by: Eric Blake <address@hidden>
>
The reasoning was the helper functions in 1/7 were to support block
commit (patch 2/7), and the helper function in 4/7 was to support the
block commit QMP command (patch 5/7), so it seemed logical to split
them.
- [Qemu-devel] [PATCH v2 2/7] block: add live block commit functionality, (continued)
- [Qemu-devel] [PATCH v2 1/7] block: add support functions for live commit, to find and delete images., Jeff Cody, 2012/09/25
- [Qemu-devel] [PATCH v2 3/7] blockdev: rename block_stream_cb to a generic block_job_cb, Jeff Cody, 2012/09/25
- [Qemu-devel] [PATCH v2 4/7] block: helper function, to find the base image of a chain, Jeff Cody, 2012/09/25
- [Qemu-devel] [PATCH v2 5/7] QAPI: add command for live block commit, 'block-commit', Jeff Cody, 2012/09/25
[Qemu-devel] [PATCH v2 6/7] qemu-iotests: add initial tests for live block commit, Jeff Cody, 2012/09/25