[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 03/45] block: fix documentation of block_job_
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH v2 03/45] block: fix documentation of block_job_cancel_sync |
Date: |
Thu, 27 Sep 2012 14:03:41 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120605 Thunderbird/13.0 |
Am 26.09.2012 17:56, schrieb Paolo Bonzini:
> Do this in a separate commit before we move the functions to
> blockjob.h.
>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> v1->v2: split out of the next patch
>
> block_int.h | 4 ++--
> 1 file modificato, 2 inserzioni(+), 2 rimozioni(-)
>
> diff --git a/block_int.h b/block_int.h
> index ac4245c..7bb95b7 100644
> --- a/block_int.h
> +++ b/block_int.h
> @@ -425,10 +425,10 @@ void block_job_cancel(BlockJob *job);
> bool block_job_is_cancelled(BlockJob *job);
>
> /**
> - * block_job_cancel:
> + * block_job_cancel_sync:
> * @job: The job to be canceled.
> *
> - * Asynchronously cancel the job and wait for it to reach a quiescent
> + * Synchronously cancel the job and wait for it to reach a quiescent
> * state. Note that the completion callback will still be called
> * asynchronously, hence it is *not* valid to call #bdrv_delete
> * immediately after #block_job_cancel_sync. Users of block jobs
I still don't agree with the s/Async/Sync/, in my opinion it contradicts
the rest of the comment. If it did cancel the job synchronously, then
the job would be immediately completed, and there would be no need to
wait for a quiescent state nor would the completion callback occur later.
Kevin
- [Qemu-devel] [PATCH v2 00/45] Block job improvements for 1.3, Paolo Bonzini, 2012/09/26
- [Qemu-devel] [PATCH v2 02/45] blockdev: rename block_stream_cb to a generic block_job_cb, Paolo Bonzini, 2012/09/26
- [Qemu-devel] [PATCH v2 04/45] block: move job APIs to separate files, Paolo Bonzini, 2012/09/26
- [Qemu-devel] [PATCH v2 05/45] block: add block_job_query, Paolo Bonzini, 2012/09/26
- [Qemu-devel] [PATCH v2 06/45] block: add support for job pause/resume, Paolo Bonzini, 2012/09/26