[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 18/41] buffered_file: opaque is MigrationState
From: |
Juan Quintela |
Subject: |
Re: [Qemu-devel] [PATCH 18/41] buffered_file: opaque is MigrationState |
Date: |
Fri, 28 Sep 2012 09:33:10 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) |
Orit Wasserman <address@hidden> wrote:
> On 09/21/2012 11:47 AM, Juan Quintela wrote:
>> It always have that type, just change it.
>> -QEMUFile *qemu_fopen_ops_buffered(void *opaque, size_t xfer_limit,
>> +QEMUFile *qemu_fopen_ops_buffered(MigrationState *migration_state,
>> + size_t xfer_limit,
>> BufferedPutFunc *put_buffer,
>> BufferedPutReadyFunc *put_ready,
>> BufferedWaitForUnfreezeFunc
>> *wait_for_unfreeze,
>>
> Again why ? this is a general buffered file not just for migration use.
It is not used for anything else. It is used only, and inlining it
removes one level of indirection. All wins on my book.
Notice that once the migration-thread patches end, this file basically
dissapears (its only reason to exist was to allow non-blocking writes").
Later, Juan.
- [Qemu-devel] [PATCH 16/41] BufferedFile: append, then flush, (continued)
- [Qemu-devel] [PATCH 16/41] BufferedFile: append, then flush, Juan Quintela, 2012/09/21
- [Qemu-devel] [PATCH 12/41] ram: introduce migration_bitmap_sync(), Juan Quintela, 2012/09/21
- [Qemu-devel] [PATCH 10/41] ram: Introduce migration_bitmap_test_and_reset_dirty(), Juan Quintela, 2012/09/21
- [Qemu-devel] [PATCH 14/41] Separate migration bitmap, Juan Quintela, 2012/09/21
- [Qemu-devel] [PATCH 17/41] buffered_file: rename opaque to migration_state, Juan Quintela, 2012/09/21
- [Qemu-devel] [PATCH 20/41] buffered_file: unfold migrate_fd_put_ready, Juan Quintela, 2012/09/21
- [Qemu-devel] [PATCH 18/41] buffered_file: opaque is MigrationState, Juan Quintela, 2012/09/21
- [Qemu-devel] [PATCH 13/41] ram: create trace event for migration sync bitmap, Juan Quintela, 2012/09/21
- [Qemu-devel] [PATCH 22/41] buffered_file: unfold migrate_fd_put_buffer, Juan Quintela, 2012/09/21
- [Qemu-devel] [PATCH 21/41] buffered_file: unfold migrate_fd_put_buffer, Juan Quintela, 2012/09/21
- [Qemu-devel] [PATCH 19/41] buffered_file: unfold migrate_fd_put_buffer, Juan Quintela, 2012/09/21
- [Qemu-devel] [PATCH 15/41] migration: Add dirty_pages_rate to query migrate output, Juan Quintela, 2012/09/21
- [Qemu-devel] [PATCH 27/41] savevm: unexport qemu_fflush, Juan Quintela, 2012/09/21