Re: [Qemu-devel] [PATCH] vfio_pci: fix build on 32-bit systems

[Anthony Liguori]

Paolo Bonzini <address@hidden> writes:

> Il 01/10/2012 20:49, Alex Williamson ha scritto:
>>> > @@ -768,7 +768,7 @@ static int vfio_dma_map(VFIOContainer *container, 
>>> > target_phys_addr_t iova,
>>> >      struct vfio_iommu_type1_dma_map map = {
>>> >          .argsz = sizeof(map),
>>> >          .flags = VFIO_DMA_MAP_FLAG_READ,
>>> > -        .vaddr = (__u64)vaddr,
>>> > +        .vaddr = (__u64)(intptr_t)vaddr,
>
> Does this need to be uintptr_t?

I don't think it matters semantically but using uintptr_t can't hurt.

Regards,

Anthony Liguori

>
> Paolo
>
>>> >          .iova = iova,
>>> >          .size = size,
>>> >      };
>> Thanks Anthony
>> 
>> Acked-by: Alex Williamson <address@hidden>