[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 06/23] target-i386: xlevel should be more than 0x800
From: |
Igor Mammedov |
Subject: |
[Qemu-devel] [PATCH 06/23] target-i386: xlevel should be more than 0x80000000, move fixup into setter |
Date: |
Tue, 2 Oct 2012 17:36:58 +0200 |
Signed-off-by: Igor Mammedov <address@hidden>
Reviewed-by: Eduardo Habkost <address@hidden>
---
target-i386/cpu.c | 14 ++++++++++----
1 files changed, 10 insertions(+), 4 deletions(-)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index 3b7bdbd..a58b30d 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -984,8 +984,17 @@ static void x86_cpuid_set_xlevel(Object *obj, Visitor *v,
void *opaque,
const char *name, Error **errp)
{
X86CPU *cpu = X86_CPU(obj);
+ uint32_t value;
- visit_type_uint32(v, &cpu->env.cpuid_xlevel, name, errp);
+ visit_type_uint32(v, &value, name, errp);
+ if (error_is_set(errp)) {
+ return;
+ }
+
+ if (value < 0x80000000) {
+ value += 0x80000000;
+ }
+ cpu->env.cpuid_xlevel = value;
}
static char *x86_cpuid_get_vendor(Object *obj, Error **errp)
@@ -1242,9 +1251,6 @@ static int cpu_x86_find_by_name(X86CPU *cpu, x86_def_t
*x86_cpu_def,
fprintf(stderr, "bad numerical value %s\n", val);
goto error;
}
- if (numvalue < 0x80000000) {
- numvalue += 0x80000000;
- }
x86_cpu_def->xlevel = numvalue;
} else if (!strcmp(featurestr, "vendor")) {
if (strlen(val) != 12) {
--
1.7.1
- Re: [Qemu-devel] [PATCH 07/23] target-i386: convert cpuid features into properties, (continued)
[Qemu-devel] [PATCH 08/23] target-i386: add stubs for hyperv_(vapic_recommended|relaxed_timing_enabled|get_spinlock_retries)(), Igor Mammedov, 2012/10/02
[Qemu-devel] [PATCH 10/23] target-i386: convert 'hv_relaxed' feature into property, Igor Mammedov, 2012/10/02
[Qemu-devel] [PATCH 09/23] target-i386: convert 'hv_spinlocks' feature into property, Igor Mammedov, 2012/10/02
[Qemu-devel] [PATCH 04/23] target-i386: filter out not TCG features if running without kvm at realize time, Igor Mammedov, 2012/10/02
[Qemu-devel] [PATCH 11/23] target-i386: convert 'hv_vapic' feature into property, Igor Mammedov, 2012/10/02
[Qemu-devel] [PATCH 16/23] target-i386: use define for cpuid vendor string size, Igor Mammedov, 2012/10/02
[Qemu-devel] [PATCH 06/23] target-i386: xlevel should be more than 0x80000000, move fixup into setter,
Igor Mammedov <=
[Qemu-devel] [PATCH 05/23] target-i386: move out CPU features initialization in separate func, Igor Mammedov, 2012/10/02
[Qemu-devel] [PATCH 22/23] target-i386: move default init of cpuid_kvm_features bitmap into CPU initializer from cpudef, Igor Mammedov, 2012/10/02
[Qemu-devel] [PATCH 15/23] target-i386: introduce vendor-override property, Igor Mammedov, 2012/10/02
[Qemu-devel] [PATCH 18/23] target-i386: replace uint32_t vendor fields by vendor string in x86_def_t, Igor Mammedov, 2012/10/02
[Qemu-devel] [PATCH 13/23] add visitor for parsing hz[KMG] input string, Igor Mammedov, 2012/10/02
[Qemu-devel] [PATCH 21/23] target-i386: move init of "hypervisor" feature into CPU initializer from cpudef, Igor Mammedov, 2012/10/02
[Qemu-devel] [PATCH 14/23] target-i386: use visit_type_hz to parse tsc_freq property value, Igor Mammedov, 2012/10/02
[Qemu-devel] [PATCH 19/23] target-i386: parse cpu_model string into set of stringified properties, Igor Mammedov, 2012/10/02
[Qemu-devel] [PATCH 20/23] target-i386: use properties to set/unset user specified features on CPU, Igor Mammedov, 2012/10/02