qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH 3/3] qemu-ga: use state dir from CONFIG_QEMUGA_STATE


From: Luiz Capitulino
Subject: [Qemu-devel] [PATCH 3/3] qemu-ga: use state dir from CONFIG_QEMUGA_STATEDIR
Date: Wed, 3 Oct 2012 14:24:19 -0300

Has the side effect of changing the default directory used to
save the freeze status file from /tmp to /var/run.

This is a beneficial change for two reasons:

 1. FHS states that programs must not assume that files in /tmp will
    still exist between invocations of the program. This defeats
        the purpose of the freeze status file

 2. FHS dictates that /var/run should be cleaned on boot, this
    automatically cleans up any stale file

Signed-off-by: Luiz Capitulino <address@hidden>
---
 qemu-ga.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/qemu-ga.c b/qemu-ga.c
index b747470..cbfd021 100644
--- a/qemu-ga.c
+++ b/qemu-ga.c
@@ -40,8 +40,8 @@
 #else
 #define QGA_VIRTIO_PATH_DEFAULT "\\\\.\\Global\\org.qemu.guest_agent.0"
 #endif
-#define QGA_PIDFILE_DEFAULT "/var/run/qemu-ga.pid"
-#define QGA_STATEDIR_DEFAULT "/tmp"
+#define QGA_PIDFILE_DEFAULT  CONFIG_QEMUGA_STATEDIR "/qemu-ga.pid"
+#define QGA_STATEDIR_DEFAULT CONFIG_QEMUGA_STATEDIR
 #define QGA_SENTINEL_BYTE 0xFF
 
 struct GAState {
-- 
1.7.12.315.g682ce8b




reply via email to

[Prev in Thread] Current Thread [Next in Thread]