qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 02/18] qemu-sockets: add Error ** to all functio


From: Luiz Capitulino
Subject: Re: [Qemu-devel] [PATCH 02/18] qemu-sockets: add Error ** to all functions
Date: Thu, 4 Oct 2012 13:41:53 -0300

On Thu, 04 Oct 2012 18:39:06 +0200
Paolo Bonzini <address@hidden> wrote:

> Il 04/10/2012 18:19, Luiz Capitulino ha scritto:
> >> >  
> >> > -int unix_listen_opts(QemuOpts *opts)
> >> > +int unix_listen_opts(QemuOpts *opts, Error **errp)
> >> >  {
> >> > -    fprintf(stderr, "unix sockets are not available on windows\n");
> >> > +    error_setg(errp, "unix sockets are not available on windows");
> > As we've discussed in a previous series, this breaks error reporting
> > for unix_listen_opts() until errp is passed _and_ the error is routed
> > to the right direction (in this case stderr).
> > 
> > Is this fixed later in this series? If it's not, when do you plan to fix it?
> 
> It is (which is why the single patch became 18), and I can move this
> hunk at the end of the series.  Note that is just for Windows code and
> should really never run.

Right:

 Reviewed-by: Luiz Capitulino <address@hidden>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]