[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [RFC 08/13] qdev-core: isolate reset register/unregister co
From: |
Eduardo Habkost |
Subject: |
[Qemu-devel] [RFC 08/13] qdev-core: isolate reset register/unregister code |
Date: |
Thu, 4 Oct 2012 16:15:28 -0300 |
The reset register/unregister code is specific to qemu-system-*, so
isolate it so it can be moved to qdev-system.c.
Signed-off-by: Eduardo Habkost <address@hidden>
---
hw/qdev-core.c | 24 ++++++++++++++++++------
1 file changed, 18 insertions(+), 6 deletions(-)
diff --git a/hw/qdev-core.c b/hw/qdev-core.c
index a5cac45..1b45e51 100644
--- a/hw/qdev-core.c
+++ b/hw/qdev-core.c
@@ -47,6 +47,21 @@ void GCC_WEAK qdev_finalize_vmstate(DeviceState *dev)
{
}
+static void qbus_register_reset(BusState *bus)
+{
+ if (bus != sysbus_get_default()) {
+ /* TODO: once all bus devices are qdevified,
+ only reset handler for main_system_bus should be registered here. */
+ qemu_register_reset(qbus_reset_all_fn, bus);
+ }
+}
+
+static void qbus_unregister_reset(BusState *bus)
+{
+ assert(bus != sysbus_get_default()); /* main_system_bus is never freed */
+ qemu_unregister_reset(qbus_reset_all_fn, bus);
+}
+
const char *qdev_fw_name(DeviceState *dev)
{
DeviceClass *dc = DEVICE_GET_CLASS(dev);
@@ -348,10 +363,8 @@ static void qbus_realize(BusState *bus)
QLIST_INSERT_HEAD(&bus->parent->child_bus, bus, sibling);
bus->parent->num_child_bus++;
object_property_add_child(OBJECT(bus->parent), bus->name, OBJECT(bus),
NULL);
- } else if (bus != sysbus_get_default()) {
- /* TODO: once all bus devices are qdevified,
- only reset handler for main_system_bus should be registered here. */
- qemu_register_reset(qbus_reset_all_fn, bus);
+ } else {
+ qbus_register_reset(bus);
}
}
@@ -685,8 +698,7 @@ static void qbus_finalize(Object *obj)
QLIST_REMOVE(bus, sibling);
bus->parent->num_child_bus--;
} else {
- assert(bus != sysbus_get_default()); /* main_system_bus is never freed
*/
- qemu_unregister_reset(qbus_reset_all_fn, bus);
+ qbus_unregister_reset(bus);
}
g_free((char *)bus->name);
}
--
1.7.11.4
- Re: [Qemu-devel] [Qemu-trivial] [RFC 01/13] qdev: kill bogus comment, (continued)
- [Qemu-devel] [RFC 02/13] qdev: split up header so it can be used in cpu.h, Eduardo Habkost, 2012/10/04
- [Qemu-devel] [RFC 06/13] qdev-core: isolate vmstate handling into separate functions, Eduardo Habkost, 2012/10/04
- [Qemu-devel] [RFC 13/13] make CPU a child of DeviceState, Eduardo Habkost, 2012/10/04
- [Qemu-devel] [RFC 12/13] include core qdev code into *-user, too, Eduardo Habkost, 2012/10/04
- [Qemu-devel] [RFC 04/13] qdev: separate core from the code used only by qemu-system-*, Eduardo Habkost, 2012/10/04
- [Qemu-devel] [RFC 10/13] move qemu_irq typedef out of cpu-common.h, Eduardo Habkost, 2012/10/04
- [Qemu-devel] [RFC 08/13] qdev-core: isolate reset register/unregister code,
Eduardo Habkost <=