[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 06/14] stellaris: Removed SSI mux
From: |
Peter Crosthwaite |
Subject: |
Re: [Qemu-devel] [PATCH 06/14] stellaris: Removed SSI mux |
Date: |
Sat, 6 Oct 2012 00:14:54 +1000 |
On Fri, Oct 5, 2012 at 10:34 PM, Peter Maydell <address@hidden> wrote:
> On 5 October 2012 01:08, Peter Crosthwaite
> <address@hidden> wrote:
>> From: Peter A. G. Crosthwaite <address@hidden>
>>
>> Removed the explicit SSI mux and wired the CS line directly up to the SSI
>> devices.
>>
>> Signed-off-by: Peter A. G. Crosthwaite <address@hidden>
>> + dev = ssi_create_slave(bus, "ssi-sd");
>> if (gpio_dev[GPIO_D]) {
>> - qdev_connect_gpio_out(gpio_dev[GPIO_D], 0, select_pin);
>> + qdev_connect_gpio_out(gpio_dev[GPIO_D], 0,
>> + qdev_get_gpio_in(dev, 0));
>> }
>>
>> - bus = qdev_get_child_bus(mux, "ssi0");
>> - ssi_create_slave(bus, "ssi-sd");
>> -
>> - bus = qdev_get_child_bus(mux, "ssi1");
>> dev = ssi_create_slave(bus, "ssd0323");
>> + if (gpio_dev[GPIO_D]) {
>> + qdev_connect_gpio_out(gpio_dev[GPIO_D], 0,
>> + qdev_get_gpio_in(dev, 0));
>> + }
>
> ...this seems to be trying to wire up two devices to the same
> GPIO output ?
>
Reimplemented using qemu_irq_split()
Regards,
Peter
> -- PMM
- [Qemu-devel] [PATCH 01/14] ssi: Support for multiple attached devices, (continued)
- [Qemu-devel] [PATCH 01/14] ssi: Support for multiple attached devices, Peter Crosthwaite, 2012/10/04
- [Qemu-devel] [PATCH 02/14] ssi: Implemented CS behaviour, Peter Crosthwaite, 2012/10/04
- [Qemu-devel] [PATCH 03/14] ssi: Added create_slave_no_init(), Peter Crosthwaite, 2012/10/04
- [Qemu-devel] [PATCH 04/14] qdev: allow multiple qdev_init_gpio_in() calls, Peter Crosthwaite, 2012/10/04
- [Qemu-devel] [PATCH 05/14] hw/stellaris: Removed gpio_out init array., Peter Crosthwaite, 2012/10/04
- [Qemu-devel] [PATCH 06/14] stellaris: Removed SSI mux, Peter Crosthwaite, 2012/10/04
- [Qemu-devel] [PATCH 07/14] hw: Added generic FIFO API., Peter Crosthwaite, 2012/10/04
- [Qemu-devel] [PATCH 10/14] petalogix-ml605: added SPI controller with n25q128, Peter Crosthwaite, 2012/10/04
- [Qemu-devel] [PATCH 13/14] MAINTAINERS: Added maintainerships for SSI, Peter Crosthwaite, 2012/10/04
- [Qemu-devel] [PATCH 11/14] xilinx_spips: Xilinx Zynq SPI cntrlr device model, Peter Crosthwaite, 2012/10/04
- [Qemu-devel] [PATCH 12/14] xilinx_zynq: Added SPI controllers + flashes, Peter Crosthwaite, 2012/10/04
- [Qemu-devel] [PATCH 14/14] ssi: Add slave autoconnect helper, Peter Crosthwaite, 2012/10/04
- [Qemu-devel] [PATCH 08/14] m25p80: Initial implementation of SPI flash device, Peter Crosthwaite, 2012/10/04
- [Qemu-devel] [PATCH 09/14] xilinx_spi: Initial impl. of Xilinx SPI controller, Peter Crosthwaite, 2012/10/04