Re: [Qemu-devel] [PATCH] tci: fix build breakage for target-sparc

[Stefan Weil]

Am 09.10.2012 00:19, schrieb Richard Henderson:
> On 10/08/2012 01:45 PM, Michael Roth wrote:
> >   /* Alpha and SH4 user mode emulations and Softmmu call GETPC().
> >      For all others, GETPC remains undefined (which makes TCI a little faster. 
> > */
> > -# if defined(CONFIG_SOFTMMU) || defined(TARGET_ALPHA) || defined(TARGET_SH4)
> > +# if defined(CONFIG_SOFTMMU) || defined(TARGET_ALPHA) || defined(TARGET_SH4) \
> > +     || defined(TARGET_SPARC)
> >   extern uintptr_t tci_tb_ptr;
> >   #  define GETPC() tci_tb_ptr
> Why is this conditional?  All targets probably ought to be using it
> when raising runtime exceptions -- particularly fp exceptions.
>
>
> r~

See the comment: "which makes TCI a little faster".

When GETPC is undefined, tci.c saves an assignment
to a global variable per interpreted TCG code
which is a significant reduction.

Maybe there are better solutions, of course.

Regards
Stefan