[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/3] e500: Adding CCSR memory region
From: |
Avi Kivity |
Subject: |
Re: [Qemu-devel] [PATCH 2/3] e500: Adding CCSR memory region |
Date: |
Tue, 09 Oct 2012 11:04:42 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120911 Thunderbird/15.0.1 |
On 10/08/2012 07:21 PM, Andreas Färber wrote:
> Am 08.10.2012 18:46, schrieb Bharat Bhushan:
>> All devices are also placed under CCSR memory region.
>> The CCSR memory region is exported to pci device. The MSI interrupt
>> generation is the main reason to export the CCSR region to PCI device.
>> This put the requirement to move mpic under CCSR region, but logically
>> all devices should be under CCSR. So this patch places all emulated
>> devices under ccsr region.
>>
>> + sysbus_connect_irq(s, 0, mpic[pci_irq_nrs[0]]);
>> + sysbus_connect_irq(s, 1, mpic[pci_irq_nrs[1]]);
>> + sysbus_connect_irq(s, 2, mpic[pci_irq_nrs[2]]);
>> + sysbus_connect_irq(s, 3, mpic[pci_irq_nrs[3]]);
>> + memory_region_add_subregion(ccsr, MPC8544_PCI_REGS_OFFSET,
>> s->mmio[0].memory);
>
> ... I wonder if fiddling with SysBus MMIO is a good idea.
> s->mmio[0].addr is not getting assigned this way, which is checked as
> condition for deleting the subregion. But sysbus_mmio_map() only adds to
> / deletes from get_system_memory().
> The alternative would be using a custom field rather than the
> SysBus-internal one. Avi/Alex?
IMO yes. Or not use sysbus at all.
--
error compiling committee.c: too many arguments to function
- Re: [Qemu-devel] [PATCH 1/3] e500: Fix serial initialization, (continued)
[Qemu-devel] [PATCH 2/3] e500: Adding CCSR memory region, Bharat Bhushan, 2012/10/08
- Re: [Qemu-devel] [PATCH 2/3] e500: Adding CCSR memory region, Andreas Färber, 2012/10/08
- Re: [Qemu-devel] [PATCH 2/3] e500: Adding CCSR memory region,
Avi Kivity <=
- Re: [Qemu-devel] [PATCH 2/3] e500: Adding CCSR memory region, Bhushan Bharat-R65777, 2012/10/09
- Re: [Qemu-devel] [PATCH 2/3] e500: Adding CCSR memory region, Avi Kivity, 2012/10/09
- Re: [Qemu-devel] [PATCH 2/3] e500: Adding CCSR memory region, Bhushan Bharat-R65777, 2012/10/09
- Re: [Qemu-devel] [PATCH 2/3] e500: Adding CCSR memory region, Avi Kivity, 2012/10/09
- Re: [Qemu-devel] [PATCH 2/3] e500: Adding CCSR memory region, Bhushan Bharat-R65777, 2012/10/09
Re: [Qemu-devel] [PATCH 2/3] e500: Adding CCSR memory region, Andreas Färber, 2012/10/08