qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 11/14] target-mips: optimize ddiv/ddivu/div/divu


From: Richard Henderson
Subject: Re: [Qemu-devel] [PATCH 11/14] target-mips: optimize ddiv/ddivu/div/divu with movcond
Date: Wed, 10 Oct 2012 13:38:46 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120911 Thunderbird/15.0.1

On 10/09/2012 01:27 PM, Aurelien Jarno wrote:
> +            tcg_gen_setcondi_tl(TCG_COND_EQ, t2, t0, INT_MIN);
> +            tcg_gen_setcondi_tl(TCG_COND_EQ, t3, t1, -1);
> +            tcg_gen_and_tl(t2, t2, t3);
> +            tcg_gen_setcondi_tl(TCG_COND_EQ, t3, t1, 0);
> +            tcg_gen_or_tl(t2, t2, t3);
> +            tcg_gen_movi_tl(t3, 1);
> +            tcg_gen_movcond_tl(TCG_COND_NE, t1, t2, t4, t3, t1);

You don't need t3.

  tcg_gen_movcond_tl(TCG_COND_NE, t1, t2, t4, t2, t1);

I.e. if true, t2 already contains 1.

That said, the patch isn't incorrect.

Reviewed-by: Richard Henderson <address@hidden>


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]