Re: [Qemu-devel] [PATCH] Add nvram to default boot device list

[Alexander Graf]

On 11.10.2012, at 04:04, Avik Sil wrote:

> This patch adds nvram specified boot device into qemu default
> boot_devices list. This helps firmware to boot from nvram specified
> boot device if no -boot option is specified.

Did you check that no other user of the boot device list gets confused by this? 
Also, this new 'x' bit needs to be documented. Plus, we need a SLOF update to 
make use of it.


Alex

> 
> Suggested by: Alexander Graf <address@hidden>
> 
> Signed-off-by: Avik Sil <address@hidden>
> ---
> vl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/vl.c b/vl.c
> index 48049ef..8adc40b 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -2349,7 +2349,7 @@ int main(int argc, char **argv, char **envp)
>     const char *icount_option = NULL;
>     const char *initrd_filename;
>     const char *kernel_filename, *kernel_cmdline;
> -    char boot_devices[33] = "cad"; /* default to HD->floppy->CD-ROM */
> +    char boot_devices[33] = "xcad"; /* default to NVRAM->HD->floppy->CD-ROM 
> */
>     DisplayState *ds;
>     DisplayChangeListener *dcl;
>     int cyls, heads, secs, translation;
> -- 
> 1.7.11.4
>