Re: [Qemu-devel] [PATCH 24/25] qmp: add NBD server commands

[Eric Blake]

On 10/11/2012 07:06 AM, Paolo Bonzini wrote:
> Il 10/10/2012 22:41, Eric Blake ha scritto:
>> On 10/10/2012 08:03 AM, Paolo Bonzini wrote:
>>> Adding an NBD server inside QEMU is trivial, since all the logic is
>>> in nbd.c and can be shared easily between qemu-nbd and QEMU itself.
>>> The main difference is that qemu-nbd serves a single unnamed export,
>>> while QEMU serves named exports.
>>>
>>> Acked-by: Luiz Capitulino <address@hidden>
>>> Signed-off-by: Paolo Bonzini <address@hidden>
>>> ---
>>
>>> +##
>>> +# @nbd-server-add:
>>> +#
>>> +# Export a device to QEMU's embedded NBD server.
>>> +#
>>> +# @device: Block device to be exported
>>> +#
>>> +# @writable: Whether clients should be able to write to the device via the
>>> +#     NBD connection (default false). #optional
>>
>> Isn't the #optional designation supposed to come first, before 'Whether'?
> 
> Does it really matter with no program yet written to consume it?
> Putting it at the end matches the old qmp-commands.hx format better (for
> commands that do have qmp-commands.hx documentation).

I'm just asking on the grounds of consistency based on observation, and
not based on an actual hard requirement of something that goes wrong if
it's out of order.  Therefore, I'm okay with your explanation, as long
as no one else can provide hard evidence for a mandatory positioning of
the marker.

-- 
Eric Blake   address@hidden    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature