[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 7/7] hw/pl031: Use LOG_GUEST_ERROR
From: |
Peter Maydell |
Subject: |
[Qemu-devel] [PATCH 7/7] hw/pl031: Use LOG_GUEST_ERROR |
Date: |
Sun, 14 Oct 2012 14:11:16 +0100 |
Use LOG_GUEST_ERROR rather than hw_error or direct fprintf.
Signed-off-by: Peter Maydell <address@hidden>
---
hw/pl031.c | 17 +++++++++++------
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git a/hw/pl031.c b/hw/pl031.c
index 9602664..a718d2e 100644
--- a/hw/pl031.c
+++ b/hw/pl031.c
@@ -14,6 +14,7 @@
#include "sysbus.h"
#include "qemu-timer.h"
#include "sysemu.h"
+#include "qemu-log.h"
//#define DEBUG_PL031
@@ -120,11 +121,13 @@ static uint64_t pl031_read(void *opaque,
target_phys_addr_t offset,
case RTC_MIS:
return s->is & s->im;
case RTC_ICR:
- fprintf(stderr, "qemu: pl031_read: Unexpected offset 0x%x\n",
- (int)offset);
+ qemu_log_mask(LOG_GUEST_ERROR,
+ "pl031: read of write-only register at offset 0x%x\n",
+ (int)offset);
break;
default:
- hw_error("pl031_read: Bad offset 0x%x\n", (int)offset);
+ qemu_log_mask(LOG_GUEST_ERROR,
+ "pl031_read: Bad offset 0x%x\n", (int)offset);
break;
}
@@ -167,12 +170,14 @@ static void pl031_write(void * opaque, target_phys_addr_t
offset,
case RTC_DR:
case RTC_MIS:
case RTC_RIS:
- fprintf(stderr, "qemu: pl031_write: Unexpected offset 0x%x\n",
- (int)offset);
+ qemu_log_mask(LOG_GUEST_ERROR,
+ "pl031: write to read-only register at offset 0x%x\n",
+ (int)offset);
break;
default:
- hw_error("pl031_write: Bad offset 0x%x\n", (int)offset);
+ qemu_log_mask(LOG_GUEST_ERROR,
+ "pl031_write: Bad offset 0x%x\n", (int)offset);
break;
}
}
--
1.7.11.4
- [Qemu-devel] [PATCH 0/7] Add LOG_GUEST_ERROR for reporting guest bugs, Peter Maydell, 2012/10/14
- [Qemu-devel] [PATCH 6/7] hw/pl022: Use LOG_UNIMP and LOG_GUEST_ERROR, Peter Maydell, 2012/10/14
- [Qemu-devel] [PATCH 5/7] hw/pl011: Use LOG_UNIMP and LOG_GUEST_ERROR, Peter Maydell, 2012/10/14
- [Qemu-devel] [PATCH 3/7] hw/pl041: Use LOG_UNIMP, Peter Maydell, 2012/10/14
- [Qemu-devel] [PATCH 2/7] hw/pl181: Use LOG_UNIMP and LOG_GUEST_ERROR, Peter Maydell, 2012/10/14
- [Qemu-devel] [PATCH 7/7] hw/pl031: Use LOG_GUEST_ERROR,
Peter Maydell <=
- [Qemu-devel] [PATCH 4/7] hw/pl190: Use LOG_GUEST_ERROR, Peter Maydell, 2012/10/14
- [Qemu-devel] [PATCH 1/7] qemu-log: Add new log category for guest bugs, Peter Maydell, 2012/10/14
- Re: [Qemu-devel] [PATCH 0/7] Add LOG_GUEST_ERROR for reporting guest bugs, Blue Swirl, 2012/10/14