Re: [Qemu-devel] [PATCH 0/3] vga: add mmio bar

[Gerd Hoffmann]

  Hi,

> Patches don't apply, please rebase:
> Applying: vga: add mmio bar to standard vga
> error: patch failed: hw/pc_piix.c:371
> error: hw/pc_piix.c: patch does not apply
> error: patch failed: hw/vga-pci.c:47
> error: hw/vga-pci.c: patch does not apply
> Patch failed at 0001 vga: add mmio bar to standard vga

Rebased & resolved.

> Also checkpatch.pl complains for 1/3:
> WARNING: suspect code indent for conditional statements (5, 9)
> #212: FILE: hw/vga-pci.c:158:
> +     if (d->flags & (1 << PCI_VGA_FLAG_ENABLE_MMIO)) {
> +         memory_region_init(&d->mmio, "vga.mmio", 4096);

Ah, finally figured where this comes from.  It's not in this patch, but
the *existing* intention is wrong (5 instead of 4 spaces).  Fixed.

v2 is on the way.

cheers,
  Gerd