Re: [Qemu-devel] [PATCHv3] tests/tcg: fix build

[Peter Maydell]

On 16 October 2012 07:53, Catalin Patulea <address@hidden> wrote:
> Sorry this got abandoned.. here is a fresh (and slightly leaner) patch on top 
> of master. Can anyone take a look?
>
> ---
> This broke when the tests were moved from tests/ to tests/tcg/.
>
> On x86_64 host/i386-linux-user non-kvm guest, test-i386 and test-mmap are 
> broken, but at least they build.
>
> To build/run the tests:
> $ cd $BUILD_PATH/tests/tcg
> $ SRC_PATH=path/to/qemu make <target>

> @@ -86,7 +90,7 @@ testthread: testthread.c
>  # i386/x86_64 emulation test (test various opcodes) */
>  test-i386: test-i386.c test-i386-code16.S test-i386-vm86.S \
>             test-i386.h test-i386-shift.h test-i386-muldiv.h
> -       $(CC_I386) $(CFLAGS) $(LDFLAGS) -o $@ \
> +       $(CC_I386) $(QEMU_INCLUDES) $(CFLAGS) $(LDFLAGS) -o $@ \
>                $(<D)/test-i386.c $(<D)/test-i386-code16.S 
> $(<D)/test-i386-vm86.S -lm

The compile line for the test-x86_64 target also needs
QEMU_INCLUDES added to it.

I can't work out how to get a working i386 compiler on my 64-bit Ubuntu system
but I think that's an Ubuntu issue :-) Tests run ok on a 32 bit native box
(there are some failures, as you say, but I'm unsurprised given how long it's
been since we ran them last.)

-- PMM