[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 0/5] target-mips: Preparations for CPUState p
From: |
Aurelien Jarno |
Subject: |
Re: [Qemu-devel] [PATCH v2 0/5] target-mips: Preparations for CPUState part 4b series |
Date: |
Wed, 17 Oct 2012 09:05:20 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Fri, Oct 12, 2012 at 12:56:32AM +0200, Andreas Färber wrote:
> Hello Aurélien,
>
> This series picks up some preparatory patches for QOM CPUState refactoring,
> originally posted in May. They still applied cleanly, but I optimized them
> a bit and expanded the explanations.
>
> In short it is about MIPSCPU vs. CPUMIPSState; more fields will be moved
> from CPU_COMMON macro to CPUState struct, and to access CPUState we need
> a MIPSCPU. Thus MIPSCPU is preferable for arguments of static helpers
> (not TCG helpers) because we save some redundant accessor/cast macros.
>
> Can you please ack/apply and keep in mind for the current patch review?
>
> Available for testing from:
> git://github.com/afaerber/qemu-cpu.git qom-cpu-mips
> https://github.com/afaerber/qemu-cpu/commits/qom-cpu-mips
>
> Regards,
> Andreas
>
> Cc: Aurélien Jarno <address@hidden>
>
> Cc: Jia Liu <address@hidden>
> Cc: Eric Johnson <address@hidden>
> Cc: Richard Henderson <address@hidden>
>
> v1 -> v2:
> * Cherry-picked from my CPUState part 4 series
> * Avoided calling mips_env_get_cpu() in both if branches of
> helper_m[t]tc0_tchalt()
> * Prepended patch to clean up resulting variable naming mess
> * Placed variable declarations in the closest block (requested by Alex
> elsewhere)
>
> Andreas Färber (5):
> target-mips: Clean up other_cpu in helper_{d,e}vpe()
> target-mips: Pass MIPSCPU to mips_tc_wake()
> target-mips: Pass MIPSCPU to mips_vpe_is_wfi()
> target-mips: Pass MIPSCPU to mips_tc_sleep()
> target-mips: Pass MIPSCPU to mips_vpe_sleep()
>
> target-mips/op_helper.c | 63
> +++++++++++++++++++++++++++++------------------
> 1 Datei geändert, 39 Zeilen hinzugefügt(+), 24 Zeilen entfernt(-)
>
> --
> 1.7.10.4
Thanks, all applied.
--
Aurelien Jarno GPG: 1024D/F1BCDB73
address@hidden http://www.aurel32.net
- [Qemu-devel] [PATCH v2 0/5] target-mips: Preparations for CPUState part 4b series, Andreas Färber, 2012/10/11
- [Qemu-devel] [PATCH v2 1/5] target-mips: Clean up other_cpu in helper_{d, e}vpe(), Andreas Färber, 2012/10/11
- [Qemu-devel] [PATCH v2 2/5] target-mips: Pass MIPSCPU to mips_tc_wake(), Andreas Färber, 2012/10/11
- [Qemu-devel] [PATCH v2 4/5] target-mips: Pass MIPSCPU to mips_tc_sleep(), Andreas Färber, 2012/10/11
- [Qemu-devel] [PATCH v2 5/5] target-mips: Pass MIPSCPU to mips_vpe_sleep(), Andreas Färber, 2012/10/11
- [Qemu-devel] [PATCH v2 3/5] target-mips: Pass MIPSCPU to mips_vpe_is_wfi(), Andreas Färber, 2012/10/11
- Re: [Qemu-devel] [PATCH v2 0/5] target-mips: Preparations for CPUState part 4b series,
Aurelien Jarno <=