Re: [Qemu-devel] [PATCH 01/18] error: add error_set_errno and error_setg_errno

[Markus Armbruster]

Luiz Capitulino <address@hidden> writes:

> On Thu, 04 Oct 2012 18:16:13 +0200
> Paolo Bonzini <address@hidden> wrote:
>
>> Il 04/10/2012 18:14, Luiz Capitulino ha scritto:
>> >> > +void error_set_errno(Error **errp, int os_errno, ErrorClass err_class,
>> >> > +                     const char *fmt, ...)
>> > 
>> > The function's name makes me expect that something else is done
>> > with os_errno
>>                                                      ^^^^
>> 
>> Why something "else"? :)
>
> What I meant is that, it's not clear from the function's name how os_errno
> is used. Actually, it gives the impression you're storing errno, but I might
> be biased :)
>
> But again, I don't have any better suggestions.

A bit long for my taste, but here goes anyway: error_set_with_errno()