[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 2/8] hw/hw.h: Add include of qemu-log.h
From: |
Igor Mammedov |
Subject: |
Re: [Qemu-devel] [PATCH v2 2/8] hw/hw.h: Add include of qemu-log.h |
Date: |
Thu, 18 Oct 2012 16:26:34 +0200 |
On Thu, 18 Oct 2012 14:11:36 +0100
Peter Maydell <address@hidden> wrote:
> Add an include of qemu-log.h to hw.h, so that device model
> code has access to these logging functions without the need
> to directly include qemu-log.h.
It would be better to include qemu-log.h to files that have
immediate dependency on it, then creating another include all
"qemu-common.h." and compile/preprocess it for every hw file.
>
> Signed-off-by: Peter Maydell <address@hidden>
> ---
> hw/hw.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/hw.h b/hw/hw.h
> index 16101de..b337ee3 100644
> --- a/hw/hw.h
> +++ b/hw/hw.h
> @@ -12,6 +12,7 @@
> #include "irq.h"
> #include "qemu-file.h"
> #include "vmstate.h"
> +#include "qemu-log.h"
>
> #ifdef NEED_CPU_H
> #if TARGET_LONG_BITS == 64
- [Qemu-devel] [PATCH v2 0/8] Add LOG_GUEST_ERROR for reporting guest bugs, Peter Maydell, 2012/10/18
- [Qemu-devel] [PATCH v2 3/8] hw/pl181: Use LOG_UNIMP and LOG_GUEST_ERROR, Peter Maydell, 2012/10/18
- [Qemu-devel] [PATCH v2 6/8] hw/pl011: Use LOG_UNIMP and LOG_GUEST_ERROR, Peter Maydell, 2012/10/18
- [Qemu-devel] [PATCH v2 4/8] hw/pl041: Use LOG_UNIMP, Peter Maydell, 2012/10/18
- [Qemu-devel] [PATCH v2 5/8] hw/pl190: Use LOG_GUEST_ERROR, Peter Maydell, 2012/10/18
- [Qemu-devel] [PATCH v2 7/8] hw/pl022: Use LOG_UNIMP and LOG_GUEST_ERROR, Peter Maydell, 2012/10/18
- [Qemu-devel] [PATCH v2 2/8] hw/hw.h: Add include of qemu-log.h, Peter Maydell, 2012/10/18
- Re: [Qemu-devel] [PATCH v2 2/8] hw/hw.h: Add include of qemu-log.h,
Igor Mammedov <=
- [Qemu-devel] [PATCH v2 8/8] hw/pl031: Use LOG_GUEST_ERROR, Peter Maydell, 2012/10/18
- [Qemu-devel] [PATCH v2 1/8] qemu-log: Add new log category for guest bugs, Peter Maydell, 2012/10/18
- Re: [Qemu-devel] [PATCH v2 0/8] Add LOG_GUEST_ERROR for reporting guest bugs, Blue Swirl, 2012/10/20