[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 08/16] block: introduce BLOCK_JOB_READY event
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v3 08/16] block: introduce BLOCK_JOB_READY event |
Date: |
Thu, 18 Oct 2012 10:58:27 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121009 Thunderbird/16.0 |
On 10/18/2012 08:49 AM, Paolo Bonzini wrote:
> Even for jobs that need to be manually completed, management may want
> to take care itself of the completion, not requiring the user to issue
> a command to terminate the job. In this case we want to avoid that
> they poll us continuously, waiting for completion to become available.
> Thus, add a new event that signals the phase switch and the availability
> of the block-job-complete command.
>
> Signed-off-by: Paolo Bonzini <address@hidden>
> +BLOCK_JOB_READY
> +---------------
> +
> +Emitted when a block job is ready to complete.
> +
> +Data:
> +
> +- "device": device name (json-string)
> +
> +Example:
> +
> +{ "event": "BLOCK_JOB_READY",
> + "data": { "device": "ide0-hd1",
> + "operation": "write",
> + "action": "stop" },
This example does not match the Data above ('operation' and 'action'
were not documented.
> + "timestamp": { "seconds": 1265044230, "microseconds": 450486 } }
Just a reminder that libvirt would still like a followup patch later in
your series but prior to qemu 1.3 that adds a 'type':'str' (or even an
enum, with 'stream', 'commit', and 'mirror'). But we already agreed it
need not hold up this particular patch.
--
Eric Blake address@hidden +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PULL for Kevin 00/16] Block job improvements part 2, Paolo Bonzini, 2012/10/18
- [Qemu-devel] [PATCH v3 01/16] block: add bdrv_query_info, Paolo Bonzini, 2012/10/18
- [Qemu-devel] [PATCH v3 02/16] block: add bdrv_query_stats, Paolo Bonzini, 2012/10/18
- [Qemu-devel] [PATCH v3 03/16] block: add bdrv_open_backing_file, Paolo Bonzini, 2012/10/18
- [Qemu-devel] [PATCH v3 04/16] block: introduce new dirty bitmap functionality, Paolo Bonzini, 2012/10/18
- [Qemu-devel] [PATCH v3 05/16] block: export dirty bitmap information in query-block, Paolo Bonzini, 2012/10/18
- [Qemu-devel] [PATCH v3 06/16] block: rename block_job_complete to block_job_completed, Paolo Bonzini, 2012/10/18
- [Qemu-devel] [PATCH v3 07/16] block: add block-job-complete, Paolo Bonzini, 2012/10/18
- [Qemu-devel] [PATCH v3 08/16] block: introduce BLOCK_JOB_READY event, Paolo Bonzini, 2012/10/18
- Re: [Qemu-devel] [PATCH v3 08/16] block: introduce BLOCK_JOB_READY event,
Eric Blake <=
- [Qemu-devel] [PATCH v3 09/16] mirror: introduce mirror job, Paolo Bonzini, 2012/10/18
- [Qemu-devel] [PATCH v3 13/16] iostatus: forward block_job_iostatus_reset to block job, Paolo Bonzini, 2012/10/18
- [Qemu-devel] [PATCH v3 14/16] mirror: add support for on-source-error/on-target-error, Paolo Bonzini, 2012/10/18
- [Qemu-devel] [PATCH v3 15/16] qmp: add pull_event function, Paolo Bonzini, 2012/10/18
- [Qemu-devel] [PATCH v3 12/16] qemu-iotests: add mirroring test case, Paolo Bonzini, 2012/10/18