[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 10/16] qmp: add drive-mirror command
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v3 10/16] qmp: add drive-mirror command |
Date: |
Fri, 19 Oct 2012 15:13:21 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121016 Thunderbird/16.0.1 |
Il 19/10/2012 14:54, Kevin Wolf ha scritto:
>> > + proto_drv = bdrv_find_protocol(target);
>> > + if (!proto_drv) {
>> > + error_set(errp, QERR_INVALID_BLOCK_FORMAT, format);
> This error message is still not fixed, and totally confusing, pointing
> at the wrong cause. No matter what changes to the error reporting we do
> later, we should add a better error string right now.
I think there's time for this before 1.3. Either we fix everything in
this series, or since this is cut-and-paste we should not fix the pasted
occurrence. Otherwise the fix will be harder to review and it's easier
to miss something.
Paolo
- [Qemu-devel] [PATCH v3 09/16] mirror: introduce mirror job, (continued)
- [Qemu-devel] [PATCH v3 09/16] mirror: introduce mirror job, Paolo Bonzini, 2012/10/18
- [Qemu-devel] [PATCH v3 13/16] iostatus: forward block_job_iostatus_reset to block job, Paolo Bonzini, 2012/10/18
- [Qemu-devel] [PATCH v3 14/16] mirror: add support for on-source-error/on-target-error, Paolo Bonzini, 2012/10/18
- [Qemu-devel] [PATCH v3 15/16] qmp: add pull_event function, Paolo Bonzini, 2012/10/18
- [Qemu-devel] [PATCH v3 12/16] qemu-iotests: add mirroring test case, Paolo Bonzini, 2012/10/18
- [Qemu-devel] [PATCH v3 16/16] qemu-iotests: add testcases for mirroring on-source-error/on-target-error, Paolo Bonzini, 2012/10/18
- [Qemu-devel] [PATCH v3 11/16] mirror: implement completion, Paolo Bonzini, 2012/10/18
- [Qemu-devel] [PATCH v3 10/16] qmp: add drive-mirror command, Paolo Bonzini, 2012/10/18