[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 25/25] hmp: add NBD server commands
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 25/25] hmp: add NBD server commands |
Date: |
Fri, 19 Oct 2012 15:57:58 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121016 Thunderbird/16.0.1 |
Il 19/10/2012 15:53, Markus Armbruster ha scritto:
> Paolo Bonzini <address@hidden> writes:
>
>> Il 19/10/2012 14:44, Markus Armbruster ha scritto:
>>> Apropos hotplug. The only way to unexport a block device is to stop the
>>> NBD server outright. Once the device backend has been exported,
>>> unplugging the device gets rid of the frontend, but the backend stays
>>> until you stop the NBD server, or you kill the backend with the big
>>> drive_del hammer.
>>
>> Right. (Though for removable devices you can just eject it, which calls
>> the close notifier).
>>
>>> Makes me wonder whether we need QMP command nbd-server-del.
>>
>> Perhaps yes, but it can be added later.
>
> Perhaps deleting the backend should automatically unexport it. I
> suspect that's not the case for the automatic delete on unplug.
No, because we keep a reference via drive_put_ref. But that's by
design, drive_del exists after all and we can add a more fine-grained
nbd_server_del too.
Paolo
- Re: [Qemu-devel] [PATCH 15/25] qemu-sockets: add error propagation to inet_connect_addr, (continued)
[Qemu-devel] [PATCH 18/25] qemu-sockets: add error propagation to Unix socket functions, Paolo Bonzini, 2012/10/10
[Qemu-devel] [PATCH 25/25] hmp: add NBD server commands, Paolo Bonzini, 2012/10/10
- Re: [Qemu-devel] [PATCH 25/25] hmp: add NBD server commands, Markus Armbruster, 2012/10/19
- Re: [Qemu-devel] [PATCH 25/25] hmp: add NBD server commands, Paolo Bonzini, 2012/10/19
- Re: [Qemu-devel] [PATCH 25/25] hmp: add NBD server commands, Luiz Capitulino, 2012/10/19
- Re: [Qemu-devel] [PATCH 25/25] hmp: add NBD server commands, Markus Armbruster, 2012/10/19
- Re: [Qemu-devel] [PATCH 25/25] hmp: add NBD server commands, Paolo Bonzini, 2012/10/19
- Re: [Qemu-devel] [PATCH 25/25] hmp: add NBD server commands, Markus Armbruster, 2012/10/19
- Re: [Qemu-devel] [PATCH 25/25] hmp: add NBD server commands,
Paolo Bonzini <=
[Qemu-devel] [PATCH 20/25] qapi: add socket address types, Paolo Bonzini, 2012/10/10
[Qemu-devel] [PATCH 19/25] build: add QAPI files to the tools, Paolo Bonzini, 2012/10/10
Re: [Qemu-devel] [PULL for Luiz 00/25] Combined qemu-sockets cleanup v2 + NBD server, Luiz Capitulino, 2012/10/16
Re: [Qemu-devel] [PULL for Luiz 00/25] Combined qemu-sockets cleanup v2 + NBD server, Markus Armbruster, 2012/10/17