qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2] tcg-i386: Use %gs prefixes for x86_64 GUEST_


From: Richard Henderson
Subject: Re: [Qemu-devel] [PATCH v2] tcg-i386: Use %gs prefixes for x86_64 GUEST_BASE
Date: Sun, 21 Oct 2012 16:24:09 +1000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121016 Thunderbird/16.0.1

On 2012-10-21 14:26, Aurelien Jarno wrote:
>> > -        if (TCG_TARGET_REG_BITS == 64) {
>> > -            /* ??? We assume all operations have left us with register
>> > -               contents that are zero extended.  So far this appears to
>> > -               be true.  If we want to enforce this, we can either do
>> > -               an explicit zero-extension here, or (if GUEST_BASE == 0)
>> > -               use the ADDR32 prefix.  For now, do nothing.  */
>> > -
> AFAIU this comment is still valid when %gs is/can not be used. Why
> removing it?
> 

Merge error.  I guess I should retain it.


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]