Re: [Qemu-devel] [PATCH] configure: Fix CONFIG_QEMU_HELPERDIR generation

[Michael Tokarev]

On 19.10.2012 23:33, Aurelien Jarno wrote:
> On Wed, Oct 17, 2012 at 07:09:25PM +0200, Jan Kiszka wrote:
>> We need to evaluate $libexecdir in configure, otherwise we literally end
>> up with "${prefix}/libexec" instead of the absolute path as
>> CONFIG_QEMU_HELPERDIR.
>>
>> Signed-off-by: Jan Kiszka <address@hidden>
>> ---
>>  configure |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/configure b/configure
>> index 353d788..e3a1780 100755
>> --- a/configure
>> +++ b/configure
>> @@ -3227,7 +3227,7 @@ echo "qemu_confdir=$qemu_confdir" >> $config_host_mak
>>  echo "qemu_datadir=$qemu_datadir" >> $config_host_mak
>>  echo "qemu_docdir=$qemu_docdir" >> $config_host_mak
>>  echo "qemu_localstatedir=$local_statedir" >> $config_host_mak
>> -echo "CONFIG_QEMU_HELPERDIR=\"$libexecdir\"" >> $config_host_mak
>> +echo "CONFIG_QEMU_HELPERDIR=\"`eval echo $libexecdir`\"" >> $config_host_mak

Somehow I missed this patch, and especially missed this
case when testing initial change.

And I think this is a wrong approach too.

This should be defined as qemu_helperdir variable instead of
CONFIG_QEMU_HELPERDIR, just like all other qemu_*dirs around,
and scripts/create_config will take care of it by expanding
the variable and providing CONFIG_QEMU_HELPERDIR #define.

Something like the attached.

Thanks,

/mjt

0001-fix-CONFIG_QEMU_HELPERDIR-generation-again.patch
Description: Text Data