Re: [Qemu-devel] [PATCH 07/14] console: don't set PixelFormat alpha fields for 32bpp

[Gerd Hoffmann]

On 10/19/12 19:02, Stefano Stabellini wrote:
> On Wed, 17 Oct 2012, Gerd Hoffmann wrote:
>> Currently it is inconstent, PixelFormat->amask is left unset whereas
>> abits and amax and ashift are filled.  As an alpha channel doesn't make
>> sense for the vga framebuffer leave all alpha fields clear.
>>
>> Signed-off-by: Gerd Hoffmann <address@hidden>
> 
> Actually the alpha mask was left to 0 on purpose to ignore it.
> At the same time we set amax, ashift and abits to signal the presence of
> an alpha byte in the pixel format.

Hmm?  I still don't see t he point of the current mix.  Either the byte
is alpha or it is unused ...

cheers,
  Gerd