[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] main: Hide F_GETFD and FD_CLOEXEC use for _WIN3
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH] main: Hide F_GETFD and FD_CLOEXEC use for _WIN32 |
Date: |
Tue, 23 Oct 2012 11:47:21 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120605 Thunderbird/13.0 |
Am 22.10.2012 19:46, schrieb Corey Bryant:
>
>
> On 10/22/2012 12:16 PM, Luiz Capitulino wrote:
>> On Mon, 22 Oct 2012 09:53:44 -0400
>> Corey Bryant <address@hidden> wrote:
>>
>>>
>>> Signed-off-by: Corey Bryant <address@hidden>
>>> ---
>>> vl.c | 2 ++
>>> 1 file changed, 2 insertions(+)
>>>
>>> diff --git a/vl.c b/vl.c
>>> index 200d849..94c667d 100644
>>> --- a/vl.c
>>> +++ b/vl.c
>>> @@ -812,11 +812,13 @@ static int parse_add_fd(QemuOpts *opts, void *opaque)
>>> return -1;
>>> }
>>>
>>> +#ifndef _WIN32
>>> if (fcntl(fd, F_GETFD) & FD_CLOEXEC) {
>>> qerror_report(ERROR_CLASS_GENERIC_ERROR,
>>> "fd is not valid or already in use");
>>> return -1;
>>> }
>>> +#endif
>>
>> Which series is this from? The command-line support for fd sets?
>>
>> qerror_report() is deprecated.
>>
>
> Kevin, please let me know if you want me to fix this. Otherwise I
> assume you'll modify the v5 patch.
Any conversion of interfaces should be done on top.
Kevin