[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] Make default boot order machine specific
From: |
Alexander Graf |
Subject: |
Re: [Qemu-devel] [PATCH 1/2] Make default boot order machine specific |
Date: |
Tue, 23 Oct 2012 15:28:50 +0200 |
On 23.10.2012, at 15:24, Anthony Liguori wrote:
> Alexander Graf <address@hidden> writes:
>
>> On 23.10.2012, at 12:09, Avik Sil wrote:
>>
>>> This patch makes default boot order machine specific instead of
>>> set globally. The default boot order can be set per machine in
>>> QEMUMachine default_machine_opts, or by the command line using
>>> -machine <machine_name>,boot=<boot_devices>, or by standard -boot
>>> option. This allows a machine to receive a NULL boot order when
>>> -boot isn't used and take an appropriate action accordingly. This
>>> helps machine boots from the devices as set in guest's non-volatile
>>> memory location in case no boot order is provided by the user.
>>>
>>> Signed-off-by: Avik Sil <address@hidden>
>>> ---
>>> hw/nseries.c | 2 ++
>>> hw/pc_piix.c | 13 ++++++++++++-
>>> hw/ppc_newworld.c | 1 +
>>> hw/ppc_oldworld.c | 1 +
>>> hw/ppc_prep.c | 1 +
>>> hw/sun4m.c | 10 ++++++++++
>>> hw/sun4u.c | 3 +++
>>
>> That feels like too much magic for my taste. Can't we have some
>> default macro (or even the explicit "cad" thing) that we push to
>> _every_ machine description out there? The next patch to implement
>> boot= for pseries would then remove this default value for the pseries
>> machine.
>
> I agree, having a default macro would avoid having to touch everything
> again for the next addition.
Well, can you override a default macro? Otherwise we will convert a few
machines now to a different boot order default, then add another default thing
for a completely different option, and the boot order modified machines miss
out the change to the macro.
Alex
- [Qemu-devel] [PATCH 0/2] Qemu boot order patch series, Avik Sil, 2012/10/23
- [Qemu-devel] [PATCH 2/2] pseries: set boot-device property only if boot order specified, Avik Sil, 2012/10/23
- [Qemu-devel] [PATCH 1/2] Make default boot order machine specific, Avik Sil, 2012/10/23
- Re: [Qemu-devel] [PATCH 1/2] Make default boot order machine specific, Alexander Graf, 2012/10/23
- Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/2] Make default boot order machine specific, David Gibson, 2012/10/23
- Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/2] Make default boot order machine specific, Alexander Graf, 2012/10/23
- Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/2] Make default boot order machine specific, David Gibson, 2012/10/23
- Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/2] Make default boot order machine specific, Avik Sil, 2012/10/23