Re: [Qemu-devel] [PATCH 06/11] quorum: Add quorum_co_flush().

[Eric Blake]

On 10/23/2012 06:23 AM, Benoît Canet wrote:
> Signed-off-by: Benoit Canet <address@hidden>
> ---
>  block/quorum.c |   13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/block/quorum.c b/block/quorum.c
> index 878d930..1b40081 100644
> --- a/block/quorum.c
> +++ b/block/quorum.c
> @@ -281,6 +281,18 @@ static BlockDriverAIOCB 
> *quorum_aio_writev(BlockDriverState *bs,
>      return &acb->common;
>  }
>  
> +static coroutine_fn int quorum_co_flush(BlockDriverState *bs)
> +{
> +    BDRVQuorumState *s = bs->opaque;
> +    int i;
> +
> +    for (i = 0; i < s->total; i++) {
> +        bdrv_co_flush(s->bs[i]);

What if any of the individual flush calls return non-zero?

> +    }
> +
> +    return 0;

Shouldn't you then do likewise?

-- 
Eric Blake   address@hidden    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature